Ticket #2381 (closed: fixed)
Enable Rotation matrix in workspaces and verify it in rebinning
Reported by: | Alex Buts | Owned by: | Alex Buts |
---|---|---|---|
Priority: | major | Milestone: | Iteration 29 |
Component: | VATES | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Anders Markvardsen |
Description
Change History
comment:1 Changed 10 years ago by Alex Buts
- Owner set to Alex Buts
- Status changed from new to assigned
comment:4 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 27 to Iteration 28
Bulk move of tickets at the end of iteration 27
comment:10 Changed 9 years ago by Alex Buts
comment:11 Changed 9 years ago by Alex Buts
comment:12 Changed 9 years ago by Alex Buts
comment:13 Changed 9 years ago by Alex Buts
comment:14 Changed 9 years ago by Alex Buts
comment:15 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 28 to Iteration 29
Bulk move of tickets at the end of iteration 28
comment:16 Changed 9 years ago by Alex Buts
comment:17 Changed 9 years ago by Alex Buts
comment:18 Changed 9 years ago by Alex Buts
comment:19 Changed 9 years ago by Alex Buts
comment:20 Changed 9 years ago by Alex Buts
comment:21 Changed 9 years ago by Alex Buts
comment:22 Changed 9 years ago by Alex Buts
comment:23 Changed 9 years ago by Alex Buts
comment:24 Changed 9 years ago by Alex Buts
comment:25 Changed 9 years ago by Alex Buts
comment:26 Changed 9 years ago by Alex Buts
comment:27 Changed 9 years ago by Alex Buts
comment:28 Changed 9 years ago by Martyn Gigg
comment:29 Changed 9 years ago by Alex Buts
comment:30 Changed 9 years ago by Alex Buts
(In [11405]) refs #2381 changed the logic behind rotationMatrix identification to consider the possibility when non-reciprocal dimensions are sitting first in the Geometry's dimension pool and reciprocal dimensions changed their locations wrt the basis dimensions (rotation matrix also includes reflections)
test for this case added
comment:31 Changed 9 years ago by Alex Buts
comment:32 Changed 9 years ago by Alex Buts
comment:33 Changed 9 years ago by Alex Buts
comment:34 Changed 9 years ago by Alex Buts
- Status changed from assigned to accepted
Should be all working fine, though all possible rotations is very difficult to verify. Will see how visual tests will go.
comment:35 Changed 9 years ago by Alex Buts
- Status changed from accepted to verify
- Resolution set to fixed
Should be all working fine, though all possible rotations is very difficult to verify. Will see how visual tests will go.
comment:36 Changed 9 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester set to Anders Markvardsen
comment:37 Changed 9 years ago by Anders Markvardsen
- Status changed from verifying to closed
A number of unit tests added which looks good. Note graphical verification needs to wait see #3011
comment:38 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 3228