Ticket #2381 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Enable Rotation matrix in workspaces and verify it in rebinning

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Iteration 29
Component: VATES Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description


Change History

comment:1 Changed 10 years ago by Alex Buts

  • Owner set to Alex Buts
  • Status changed from new to assigned

comment:2 Changed 10 years ago by Alex Buts

(In [9412]) refs #2381 Class Dimension got V3D direction, which defines the direction of reciprocal dimensions in reciprocal space

comment:3 Changed 10 years ago by Alex Buts

(In [9416]) refs #2381 Added missing parts for IMDDimension in different parts of Mantid

comment:4 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:5 Changed 10 years ago by Alex Buts

(In [9938]) refs #2381 added necessary transformations for quaternions and tests for them.

comment:6 Changed 9 years ago by Alex Buts

(In [10831]) refs #2381 MDGeometry modified back to expose IMDDimensions only MDGeometryBasis and basis dimensions changed to accept directions necessary for rotations

comment:7 Changed 9 years ago by Alex Buts

(In [10832]) refs #2381 unix problem with FLT_EPSILON presumably fixed

comment:8 Changed 9 years ago by Alex Buts

(In [10836]) refs #2381 Removed virtual key-word from derived dimensions to get rid of annoying warning messages on some systems.

comment:9 Changed 9 years ago by Russell Taylor

(In [10838]) Fix tests build. Re #2381.

comment:10 Changed 9 years ago by Alex Buts

(In [10862]) refs #2381 Changed to IMD everywhere (hopefully) and enabled HoraceReader to read UnitCell

comment:11 Changed 9 years ago by Alex Buts

(In [10883]) refs #2381 Changed to IMD where found more and fixed a bug with pixel size in rebinning/Horace_reader

comment:12 Changed 9 years ago by Alex Buts

(In [10915]) refs #2381 Changed to IMD where found plus prototype for rotations (not completed)

comment:13 Changed 9 years ago by Alex Buts

(In [10997]) refs #2381 hopefully fixed warning on this machine. Committed to check on other available

comment:14 Changed 9 years ago by Alex Buts

(In [10998]) refs #2381 get rid of another bunch of warnings, mainly induced by changes of nDimensions to size_t (who needed this?)

comment:15 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:16 Changed 9 years ago by Alex Buts

(In [11234]) refs #2381 MDGeometry basis modified to be orthogonal Unit cell modified to have method, which returns the rotation needed; All operations with this rotation are not fully tested yet.

comment:17 Changed 9 years ago by Alex Buts

(In [11235]) refs #2381 fixed compiler error under linux (FLT_EPSILON definition)

comment:18 Changed 9 years ago by Alex Buts

(In [11285]) refs #2381 Unit cell modified to have method, which returns the rotation, needed for MDGeometry; Tests for UnitCell modified accordingly.

comment:19 Changed 9 years ago by Alex Buts

(In [11286]) refs #2381 mix-up with g_log fixed

comment:20 Changed 9 years ago by Alex Buts

(In [11385]) refs #2381 This seems conclude modifications to geometry More tests are needed for algorithms etc...

comment:21 Changed 9 years ago by Alex Buts

(In [11386]) refs #2381 disabled failing tests temporary, as modifications are not completed

comment:22 Changed 9 years ago by Alex Buts

(In [11387]) refs #2381 disabled failing tests temporary, as modifications are not completed

comment:23 Changed 9 years ago by Alex Buts

(In [11388]) refs #2381 disabled failing tests temporary, as modifications are not completed

comment:24 Changed 9 years ago by Alex Buts

(In [11389]) refs #2381 disabled failing tests temporary, as modifications are not completed

comment:25 Changed 9 years ago by Alex Buts

(In [11390]) refs #2381 added missing component to default geometry constructor

comment:26 Changed 9 years ago by Alex Buts

(In [11391]) refs #2381 MDDataObject tests back to normal

comment:27 Changed 9 years ago by Alex Buts

(In [11394]) refs #2381 some MDAlgorithm rebinning tests are back to normal

comment:28 Changed 9 years ago by Martyn Gigg

(In [11396]) Get the build servers going again. Re #2381

comment:29 Changed 9 years ago by Alex Buts

(In [11397]) refs #2381 more tests back to normal

comment:30 Changed 9 years ago by Alex Buts

(In [11405]) refs #2381 changed the logic behind rotationMatrix identification to consider the possibility when non-reciprocal dimensions are sitting first in the Geometry's dimension pool and reciprocal dimensions changed their locations wrt the basis dimensions (rotation matrix also includes reflections)

test for this case added

comment:31 Changed 9 years ago by Alex Buts

(In [11406]) refs #2381 more tests back to normal

comment:32 Changed 9 years ago by Alex Buts

(In [11409]) refs #2381 all tests should go back to normal

comment:33 Changed 9 years ago by Alex Buts

(In [11411]) refs #2381 minor warning fixed

comment:34 Changed 9 years ago by Alex Buts

  • Status changed from assigned to accepted

Should be all working fine, though all possible rotations is very difficult to verify. Will see how visual tests will go.

comment:35 Changed 9 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

Should be all working fine, though all possible rotations is very difficult to verify. Will see how visual tests will go.

comment:36 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:37 Changed 9 years ago by Anders Markvardsen

  • Status changed from verifying to closed

A number of unit tests added which looks good. Note graphical verification needs to wait see #3011

comment:38 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3228

Note: See TracTickets for help on using tickets.