Ticket #2393 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

LoadSNSEventNexus: don't create empty pixels when loading only 1 bank.

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: minor Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

... add an option for this purpose.

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

Results from the following script:

import time
file = "/home/8oz/Desktop/topaz.cal"
CreateCalFileByNames("TOP", file, "bank9")

for singleBank in [False, True]:
	print "Starting with SingleBankPixelsOnly",  singleBank
	start = time.time()
	LoadSNSEventNexus(Filename="/home/8oz/data/TOPAZ_1786_event.nxs",OutputWorkspace="TOP",BankName="bank9",Precount="0", SingleBankPixelsOnly=singleBank)
	Sort("TOP")
	AlignDetectors(InputWorkspace="TOP",OutputWorkspace="TOP",CalibrationFile=file)
	DiffractionFocussing(InputWorkspace="TOP",OutputWorkspace="TOP_foc",GroupingFileName=file)
	print time.time() - start, " seconds."

Results:

Starting with SingleBankPixelsOnly False
53.2949681282  seconds.
Starting with SingleBankPixelsOnly True
38.5822250843  seconds.

comment:3 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [9408]) Fixes #2393: LoadSNSEventNexus to load only one bank and not pad all the other empty pixels.

comment:4 Changed 10 years ago by Russell Taylor

(In [9421]) Catch exceptions thrown out of parallel region. Re #2393.

comment:5 Changed 10 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:6 Changed 10 years ago by Vickie Lynch

  • Status changed from verifying to closed

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3240

Note: See TracTickets for help on using tickets.