Ticket #2426 (closed: fixed)
Use executeAsSubAlg() in more places to run child algoritms.
Reported by: | Janik Zikovsky | Owned by: | Janik Zikovsky |
---|---|---|---|
Priority: | trivial | Milestone: | Iteration 29 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Martyn Gigg |
Description
Refs #2319. There are about 20 spots where it could use it:
Mantid Framework Algorithms src CalculateEfficiency.cpp 66: childAlg->execute(); CalculateTransmission.cpp (2 matches) 189: childAlg->execute(); 224: childAlg->execute(); ConvertUnits.cpp 656: childAlg->execute(); DetectorDiagnostic.cpp (2 matches) 72: childAlg->execute(); 204: childAlg->execute(); DiffractionFocussing.cpp (3 matches) 98: childAlg->execute(); 177: childAlg->execute(); 214: childAlg->execute(); FindDeadDetectors.cpp 148: childAlg->execute(); FlatBackground.cpp 313: childAlg->execute(); GetEi.cpp 261: childAlg->execute(); GetEi2.cpp (2 matches) 239: childAlg->execute(); 499: childAlg->execute(); HRPDSlabCanAbsorption.cpp 176: childAlg->execute(); MedianDetectorTest.cpp 175: childAlg->execute(); NormaliseToMonitor.cpp 225: childAlg->execute(); RemoveBins.cpp 211: childAlg->execute(); SumRowColumn.cpp 112: childAlg->execute(); Unwrap.cpp 400: childAlg->execute();
Change History
comment:1 Changed 9 years ago by Nick Draper
- Status changed from new to assigned
- Owner set to Janik Zikovsky
comment:4 Changed 9 years ago by Janik Zikovsky
- Status changed from accepted to verify
- Resolution set to fixed
comment:5 Changed 9 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
comment:6 Changed 9 years ago by Peter Peterson
- Status changed from verifying to reopened
- Resolution fixed deleted
I'm sure that things were perfectly clean when you originally closed the ticket, but a couple cropped up that you should deal with.
$ ack-grep "childAlg->execute\(\)" Code/Mantid/Framework/ Code/Mantid/Framework/Algorithms/src/DetectorDiagnostic.cpp 193: childAlg->execute(); Code/Mantid/Framework/Algorithms/src/MedianDetectorTest.cpp 184: childAlg->execute(); Code/Mantid/Framework/Algorithms/src/FindDeadDetectors.cpp 157: childAlg->execute();
comment:8 Changed 9 years ago by Janik Zikovsky
- Status changed from accepted to verify
- Resolution set to fixed
In each of these cases the algorithms needed some custom error handling that would not work with executeAsSubAlg(), so these will be skipped.
comment:9 Changed 9 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester changed from Peter Peterson to Martyn Gigg
comment:10 Changed 9 years ago by Martyn Gigg
Confirmed widespread usage of executeAsSubAlg.
comment:11 Changed 9 years ago by Michael Reuter
- Status changed from verifying to closed
Looks like this should have been closed.
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 3273
Note: See
TracTickets for help on using
tickets.