Ticket #2447 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

MantidPlot versions and dates are inconsistent

Reported by: Martyn Gigg Owned by: Janik Zikovsky
Priority: critical Milestone: Iteration 28
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

MantidPlot shows a variety of different dates/versions depending on where you look. This looks quite sloppy.

Haromize the versioning info to use the Framework MantidVersion file.

Change History

comment:1 Changed 10 years ago by Martyn Gigg

(In [9526]) Add a dependency on MantidPlot to the src directory so that the generated makefiles have the correct dependencies. On Windows this means then that the MantidAbout object is correctly updated. Also slightly updated the locations of various version information so that it is consistent. Re #2447

comment:2 Changed 10 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:3 Changed 10 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 10 years ago by Steve Williams

  • Status changed from verify to verifying
  • Tester set to Steve Williams

comment:5 Changed 10 years ago by Steve Williams

  • Status changed from verifying to closed

Mantidplot's Help->About and the splash screen both agree and with sensible dates and version numbers on:

  • windows
  • mac
  • redhat

The Mantid log show the Mantid version which may be a little different from the Mantidplot version, depending on the build servers, but this is understandable.

comment:6 Changed 10 years ago by Janik Zikovsky

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:7 Changed 10 years ago by Janik Zikovsky

  • Status changed from reopened to accepted
  • Owner changed from Martyn Gigg to Janik Zikovsky

I have found that the version given by MantidPlot is sometimes older than the framework SVN revision. This is due to cmake changing MantidVersion.h only when it is run. Make alone does not do it.

comment:8 Changed 10 years ago by Janik Zikovsky

(In [9920]) Refs #2447: Make MantidPlot return a version number without starting Qt.

comment:9 Changed 10 years ago by Janik Zikovsky

(In [9921]) Refs #2447: Do-nothing change to test SVN versions.

comment:10 Changed 10 years ago by Janik Zikovsky

(In [9922]) Refs #2447: Do-nothing change to test SVN versions.

comment:11 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Note: It looks like Hudson calls cmake before make; this updates MantidVersion.h properly and so on Hudson/Jenkins jobs, the version is up-to-date.

The ISIS build servers will eventually use cmake and hudson also, so this will solve the problem there. People manually building should manually run cmake before make to ensure up-to-date versions (if they care ;) )

comment:12 Changed 9 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester changed from Steve Williams to Russell Taylor
  • Milestone changed from Iteration 27 to Iteration 28

comment:13 Changed 9 years ago by Russell Taylor

  • Status changed from verifying to closed

Changes made under #2722 mean they're definitely the same.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3294

Note: See TracTickets for help on using tickets.