Ticket #2460 (assigned)

Opened 10 years ago

Last modified 5 years ago

Review path usage in the ConfigService

Reported by: Martyn Gigg Owned by: Stuart Campbell
Priority: major Milestone: Backlog
Component: Framework Keywords: CODEREVIEW
Cc: Blocked By:
Blocking: Tester:

Description

Our handling of paths in the ConfigService is a little out of control.

In most circumstances we try to not use windows style paths and this has led to problems in circumstances where this has been missed. For example #2445.

The only issue with windows-style paths is when they appear in the Mantid properties file. At this point Poco transforms valid escape sequences and we can't do anything about this.

What we can do is only care about this slash handling on loading/saving the file, i.e when read in the paths would be stored in native format but when written out we would use either a forward slash or backward slash.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Stuart Campbell

Perhaps a first candidate for the code review swat team?

comment:2 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:3 Changed 9 years ago by Stuart Campbell

  • Status changed from assigned to accepted

comment:4 Changed 9 years ago by Stuart Campbell

  • Keywords CODEREVIEW added
  • Status changed from accepted to assigned
  • Milestone changed from Iteration 29 to Iteration 30

This will be looked at by the code review meeting.

comment:5 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:6 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:7 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:8 Changed 8 years ago by Stuart Campbell

  • Milestone changed from Release 2.2 to Release 2.3

comment:9 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:10 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:11 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:12 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:13 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:14 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:15 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3308

Note: See TracTickets for help on using tickets.