Ticket #2472 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Lack of source component in ARGUS instrument definition can cause crashes

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description

The ARGUS XML instrument definition file has it's source component commented out (and always has done). This causes a crash if, for example, you try to save an argus workspace to nexus or look at the detector table.

Change History

comment:1 Changed 10 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Russell Taylor

(In [9553]) Check for null source and sample in MatrixWorkspace::detectorTwoTheta method. An exception is thrown if either is missing (previously it would merrily try to dereference a null pointer). Re #2472.

comment:3 Changed 10 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:5 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

tested in [9556] - mantid does not crash when doing these things.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3319

Note: See TracTickets for help on using tickets.