Ticket #2537 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Fit function toolbar improvements

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description (last modified by Nick Draper) (diff)

Here are a few bugs/requests for the fit function dialog

1) The plot guess button only shows up if the select multiple peaks button is clicked.  It should show up as soon as a function is defined
2) Pressing fit with an Intensity of 0 causes a seg fault.  It should raise an error flag instead.  I only tested this with the Ikeda-CarpenterPV function
3) Pressing fit when all the parameters are fixed gives an error.  My instinct says it should work returning a chisquare.  Maybe the cleaner operation would be
to add a single iteration button and an error message if all the parameters are fixed.  The purpose of  single iteration button is so you can calculate the chisquare and the covariance matrix 
for your guess function.
4) More advanced fitting interface.  I think there should be an advanced user function that will execute a piece of python code.  It means the users will have to conform to an api, but it should give a link to all the glory of python,
ie, gamma functions, bessel functions,  wrapping C code, etc.

Garrett

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Description modified (diff)

Number 4 should not be attempted under this ticket.

comment:2 Changed 10 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:5 Changed 9 years ago by Roman Tolchenov

  • Status changed from assigned to accepted

comment:6 Changed 9 years ago by Roman Tolchenov

In [13882]:

Fit doesn't crash if called with a fixed function but returns a workspace with calculated values and the chi squared. re #2537

comment:7 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:8 Changed 9 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

I should have read the first comment earlier...

comment:9 Changed 9 years ago by Andrei Savici

Point 1 is not fixed

comment:10 Changed 9 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:11 Changed 9 years ago by Vickie Lynch

  • Status changed from verifying to closed

Points 1 and 4 should be tickets for next iteration. Points 2 and 3 are fixed.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3384

Note: See TracTickets for help on using tickets.