Ticket #254 (closed: fixed)

Opened 12 years ago

Last modified 5 years ago

Instrument display: Unwrap to flat view

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: critical Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description (last modified by Nick Draper) (diff)

Allow the instrument view to display two other modes

  1. 3D (current)
  2. 2D Cylindrical (plot theta-y)
  3. 2D Spherical (plot theta-phi)

For the 2D views the resulting image should be static (no rotation or panning) but should support (as the 3D view) in order:

  1. picking
  2. colour mapping
  3. integration limits
  4. zooming
  5. Instrument tree selection

Change History

comment:1 Changed 12 years ago by Nick Draper

  • Owner set to Sri Nagella
  • Priority changed from major to minor
  • Milestone changed from Iteration 13 to Iteration 14

comment:2 Changed 12 years ago by Nick Draper

  • Owner Sri Nagella deleted
  • Priority changed from minor to major
  • Milestone Iteration 14 deleted

comment:3 Changed 12 years ago by Nick Draper

  • Milestone set to Unassigned

comment:4 Changed 11 years ago by Nick Draper

  • Owner set to Martyn Gigg
  • Status changed from new to assigned
  • Description modified (diff)
  • Milestone changed from Unassigned to Iteration 22

comment:5 Changed 11 years ago by Nick Draper

  • Priority changed from major to minor

comment:6 Changed 10 years ago by Nick Draper

  • Priority changed from minor to critical
  • Component set to Mantid
  • Description modified (diff)

comment:7 Changed 10 years ago by Nick Draper

  • Owner changed from Martyn Gigg to Roman Tolchenov

comment:8 Changed 10 years ago by Roman Tolchenov

  • Status changed from assigned to accepted

comment:9 Changed 10 years ago by Roman Tolchenov

(In [7789]) Added unwrapped view to the instrument window, re #254. Added the segmented cylinder shape to handle scaled psds better, re #1831

comment:10 Changed 10 years ago by Roman Tolchenov

(In [7791]) linux build fix. re #254

comment:11 Changed 10 years ago by Roman Tolchenov

(In [7826]) Added detector picking functions to the unwrapped surfaces. re #254

comment:12 Changed 10 years ago by Roman Tolchenov

(In [7863]) Connected the unwrapped view to the instrument tree widget. re #254

comment:13 Changed 10 years ago by Roman Tolchenov

(In [8001]) Fixed picture disappearance in the pick mode, added more gl error checks. re #254

comment:14 Changed 10 years ago by Roman Tolchenov

(In [8003]) linux build fix. re #254

comment:15 Changed 10 years ago by Roman Tolchenov

(In [8005]) re #254

comment:16 Changed 10 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:17 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:18 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Getting messages in the Results Log along the lines of: 

OpenGL error detected in GLViewport::issueGL(): invalid value
Arguments to glOrtho:
-1,1,-1.#IND,-1.#IND,-1,1

OpenGL error detected in GLViewport::issueGL(): invalid value
Arguments to glOrtho:
-1.47486,1.455,-1.#IND,-1.#IND,-41.12,75.175

OpenGL error detected in UnwrappedSurface::drawSurface: invalid value
OpenGL error detected in UnwrappedSurface::drawSurface: invalid value

when viewing the IRIS instrument in Instrument view, changing between the view types (Full 3D, Cylindrical *, Spherical *) etc.

comment:19 Changed 10 years ago by Roman Tolchenov

  • Status changed from reopened to accepted

comment:20 Changed 10 years ago by Roman Tolchenov

(In [8140]) Accounted for instruments with all detectors lying on one line. re #254

comment:21 Changed 10 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:22 Changed 10 years ago by Roman Tolchenov

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:23 Changed 10 years ago by Roman Tolchenov

(In [8145]) Fixed bug introduced in the previous check in. re #254

comment:24 Changed 10 years ago by Roman Tolchenov

  • Status changed from reopened to accepted

comment:25 Changed 10 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:26 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:27 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 26

Sorry I didn't mean to move these ones reverting back to It 26

comment:28 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying

comment:29 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

still receive the following errors in the Results Log when initially openning the instrument view: 

OpenGL error detected in GLViewport::issueGL(): invalid value
Arguments to glOrtho:
-1,1,-1.#IND,-1.#IND,-1,1

OpenGL error detected in GLViewport::issueGL(): invalid value
Arguments to glOrtho:
-1,1,-1.#IND,-1.#IND,-1,1

OpenGL error detected in GLViewport::issueGL(): invalid value
Arguments to glOrtho:
-1,1,-1.#IND,-1.#IND,-1,1

OpenGL error detected in GLViewport::issueGL(): invalid value
Arguments to glOrtho:
-1.47486,1.455,-1.#IND,-1.#IND,-41.12,75.175

but the cylindrical/spherical seem to work ok and these do not seem to prevent functionality.

things seem to do what one would expect. so passing testing and creating a new ticket (#2086) for these errors.

comment:30 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1102

Note: See TracTickets for help on using tickets.