Ticket #2565 (closed: fixed)
Source tarball does not build with CMake
Reported by: | Martyn Gigg | Owned by: | Russell Taylor |
---|---|---|---|
Priority: | major | Milestone: | Iteration 28 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Stuart Campbell |
Description
The source tarball created by the RPM scripts will not build with CMake as it is not a subversion working copy.
In this case we should write out the version necessary header files and include them in the source and then update the CMake scripts so that they can run on a non-svn copy.
Change History
comment:2 Changed 10 years ago by Russell Taylor
The changed default on the flag above will allow builds out of the box on the source tarball. However, it will create the version headers with 0 for the revision number, which may not be what we want in this particular situation.
comment:3 Changed 10 years ago by Russell Taylor
This problem can be solved by using a source tarball created by cmake/cpack. This will contain the already-generated MantidVersion.h. We just need to modify the CMakeLists to not overwrite it with a zero in this circumstance (i.e. test for not a working copy, but MantidVersion.h already exists).
comment:4 Changed 9 years ago by Nick Draper
- Owner set to Russell Taylor
- Status changed from new to assigned
comment:5 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 28 to Iteration 29
Bulk move of tickets at the end of iteration 28
comment:6 Changed 9 years ago by Russell Taylor
- Status changed from assigned to accepted
- Milestone changed from Iteration 29 to Iteration 28
comment:7 Changed 9 years ago by Russell Taylor
- Status changed from accepted to verify
- Resolution set to fixed
comment:8 Changed 9 years ago by Stuart Campbell
- Status changed from verify to verifying
- Tester set to Stuart Campbell
comment:9 Changed 9 years ago by Stuart Campbell
I get a source tarball, but it contains files with strange paths like:
mantid-1.28.11131-Source/usr/local/Framework/UserAlgorithms/PropertyAlgorithm.cpp
comment:10 Changed 9 years ago by Stuart Campbell
- Status changed from verifying to closed
follow up ticket #2881
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 3412
(In [10315]) Switch SVN_WORKING_COPY default to OFF. Buildservers creating install kits will need to be sure to turn it on or the revision number will show zero. Re #2565.