Ticket #2591 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Log filtering: bug with some logs with few / constant values

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: minor Milestone: Iteration 28
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

When filtering events (on reading especially) you chop up the logs. With PG3 (and other instruments) if a value is logged once because it is a constant for the run its value will get dropped unless you read in the first part of the file. I'm not sure whether it is better to copy the 'entire' log if it only has one value, or to copy the whole thing every time and just mess with what information gets into the statistics calls. Either way, read in the second half hour of PG3_1370 and look for SpeedRequest1. You will find a time series property without any values.

P2

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [9824]) Fixes #2591: filter a log with one value = it is a constant, don't delete it.

comment:3 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to reopened
  • Resolution fixed deleted

I probably shouldn't be doing it this way….

PG3_2548, FilterByTime from 0 to 100,000 seconds. The logs that were multi-valued get completely clipped off. I'm suspicious that there is something wrong with the timing of everything as this is a recovered run.

P2

comment:4 Changed 10 years ago by Janik Zikovsky

  • Status changed from reopened to accepted

comment:5 Changed 10 years ago by Janik Zikovsky

(In [10026]) Refs #2591: Workaround for DAS pulse time bug.

comment:6 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 9 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:8 Changed 9 years ago by Andrei Savici

  • Status changed from verifying to closed

Works as expected

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3438

Note: See TracTickets for help on using tickets.