Ticket #2697 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Parallelization in SolidAngle cause Mantid to crash

Reported by: Michael Whitty Owned by: Nick Draper
Priority: major Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Reproduction steps: 

LoadRaw('OSI87371', 'OSI87371')
SolidAngle('OSI87371', 'OSI87371')

Removing the openMP macros from the algorithm stops this happening. Doesn't co-operate with debugger, so can't step into it.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:2 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:6 Changed 8 years ago by Nick Draper

  • Status changed from new to accepted

comment:7 Changed 8 years ago by Nick Draper

This seems to be a problem just with Osiris files

comment:8 Changed 8 years ago by Nick Draper

Actually it is a problem with any files with complex shapes that require opencascade triangulation. So GEM and HRPD should fail as well (haven't tried this). Anyway it is a problem with the geometry cache not being thread safe. I've put a critical section aroung triangulate.

To test:

  • Make sure you do not have a vtp file for osiris
  • Load any osiris file
  • run solidangle (on the whole thing)

comment:9 Changed 8 years ago by Nick Draper

re #2697 added ctirical section to triangulate

Changeset: de019d03c254fa445700d88de0739fbff247b85a

comment:10 Changed 8 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:12 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:13 Changed 8 years ago by Nick Draper

re #2697 added ctirical section to triangulate

Changeset: de019d03c254fa445700d88de0739fbff247b85a

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3544

Note: See TracTickets for help on using tickets.