Ticket #26 (closed: fixed)

Opened 13 years ago

Last modified 5 years ago

Create a SaveCSV data handling command

Reported by: Nick Draper Owned by: Anders Markvardsen
Priority: major Milestone: Iteration 3
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

Create a data handling command capable of saving to a (comman, tab, user specified) seperated file the contents for a workspace.

Change History

comment:1 follow-up: ↓ 5 Changed 13 years ago by Nick Draper

Input parameters need to be
InputData - the name of the workspace containing the data to be saved
File - the name of the file to be used
Seperator - the item seperator string default ","
LineSeperator - the seperator between lines default "\n"

comment:2 Changed 13 years ago by Nick Draper

  • Owner set to Anders Markvardsen

Initially you should create a simple implmentation to be able to save a Workspace1D data to file.

After that is working and has a few simple unit tests then you should check it in and start considering a more generic way of saving the data in the workspaces that can also cover the other specialisations of workspaces. Something similar to that used in GAUDI may be a usefull approach eg. having each workspace able to serialise it's data and the SaveCSV command be able to convert the serilised data into a sensinble file format.

comment:3 Changed 13 years ago by Anders Markvardsen

  • Status changed from new to assigned

comment:4 Changed 13 years ago by Anders Markvardsen

(In [121]) Added SaveCSV algorithm for saving a 1D workspace to a CSV file. Refs #26.

comment:5 in reply to: ↑ 1 ; follow-up: ↓ 6 Changed 13 years ago by Anders Markvardsen

Replying to Nick Draper:

Input parameters need to be
InputWorkspace - the name of the workspace containing the data to be saved
Filename - the name of the file to be used
Seperator - the item seperator string default ","
LineSeperator - the seperator between lines default "\n"

comment:6 in reply to: ↑ 5 Changed 13 years ago by Anders Markvardsen

Still getting my head around how to use this ticket system.

The reason for replying to the first comment:1 is to inform that the input property names for the SaveCSV algorithm ended up with slightly different names then originally proposed. The reason for this was to be consistent with the property names already used in the LoadRaw algorithm.

Replying to Anders Markvardsen:

Replying to Nick Draper:

Input parameters need to be
InputWorkspace - the name of the workspace containing the data to be saved
Filename - the name of the file to be used
Seperator - the item seperator string default ","
LineSeperator - the seperator between lines default "\n"

comment:7 Changed 13 years ago by Anders Markvardsen

(In [130]) Added linux32 versions of the Poco-1.3.1 library files. Refs #26

comment:8 Changed 13 years ago by Anders Markvardsen

(In [137]) Fix relative path error in LoadRawTest.h caused by test file HET15868.RAW been moved from Test/ to Test/Data/. Refs #26.

comment:9 Changed 13 years ago by Anders Markvardsen

(In [152]) Added boost library which match the include/boost/filesystem.hpp boost header file version 1_34. Notice the commit text for commit number 146 saids that the boost headers added in that commit are version 1_43. This is a typing error it should read 1_34. For future reference: only the libboost_filesystem.a was added at this point. In addition the .so, multitreaded and/or debugging versions of this library may be added later. Refs #26.

comment:10 Changed 13 years ago by Anders Markvardsen

(In [153]) Added the 32bit version of the library added in commit 152 which goes together with the boost filesystem header. Refs #26.

comment:11 Changed 13 years ago by Anders Markvardsen

(In [201]) Make it consistent how the library reference to libpython is created in the Build/ and Build/Test SConstructs. Refs #26.

comment:12 Changed 13 years ago by Nick Draper

  • Milestone changed from Iteration 1 to Iteration 4

comment:13 Changed 13 years ago by Anders Markvardsen

(In [258]) Added test script for the SaveCSV class! It was tested on linuxs1 using Russell runTest script. Also, this test script links to boost_filesystem. A -lboost_filesystem was added to SConstruct in the Builds/Tests directory. Notice currently the Build/Tests/SConstruct is currently failing on the builds, so SaveCSVTest.h was not tested against this SConstruct for this submit. Refs #26.

comment:14 Changed 13 years ago by Anders Markvardsen

(In [302]) Two things. 1) In the commit 258 I forgot to add the file SaveCSVTest.h. 2) Modified SaveCSV such that it allows 2D workspaces to be saved to disk using a format described in the doxygen documentation. Refs #26.

comment:15 Changed 13 years ago by Anders Markvardsen

  • Status changed from assigned to closed
  • Resolution set to fixed

Considering a more generic way of saving the data in the workspaces will be dealt with later.

comment:16 Changed 13 years ago by Anders Markvardsen

  • Status changed from closed to reopened
  • Resolution fixed deleted

To add boost_filesystem libraries to get SaveCSVTest to pass on build server.

comment:17 Changed 13 years ago by Anders Markvardsen

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [308]) Added boost_filesystem libraries so that SaveCSVTest should pass ok on build server. Closes #26.

comment:18 Changed 13 years ago by Nick Draper

  • Milestone changed from Iteration 4 to Iteration 3

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 874

Note: See TracTickets for help on using tickets.