ConvertUnitsTest has incorrect 'standard' values.

[Stuart Campbell]

For the testDeltaE() unit test in ConvertUnitsTest there is a discrepancy whether you load the instrument from the RAW file for the instrument definition. So loading MAR11060.raw and then converting to energy (Ei=12) you get a difference in the blocksize. (line 218)

For the RAW file: blocksize = 472 For the IDF file: blocksize = 475

The current test fails to load the IDF because it uses the beamline name "MAR" to find the IDF - so then loads the geometry from the RAW.

If you do this test manually in Mantid, you get the value for using the IDF.

I am going to tighten up the looking up of instrument name to use the FacilityInfo, so this will mean that this test will correctly get the instrument name and therefore find the IDF and therefore fail the test.

I will change the expected value to the one from the IDF for now.

[Stuart Campbell]

(In [10367]) Remove ugly hack to get long instrument names in getInstrumentFilename(). Make sure we set the facility in the tests. Modify ConvertUnitsTest to account for fixed bug in correctly determining instrument long name for MARI. refs #1522 & #2730

[Stuart Campbell]

(In [10381]) I give up for the moment. Change back to the value determined from RAW file. refs #1522 & #2730

[Stuart Campbell]

(In [10445]) Let's try again. refs #1522 & #2730

[Andrei Savici]

Works.

[Stuart Campbell]

This ticket has been transferred to github issue ​3577