Ticket #2745 (closed: fixed)
Modify save nxspe option and nxspe file format to keep L2 and correct angular values
Reported by: | Alex Buts | Owned by: | Alex Buts |
---|---|---|---|
Priority: | major | Milestone: | Iteration 29 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Andrei Savici |
Description
Current nxspe file format contains the information about angular positions of the detectors. This information is calculated from instrument's description by save nxspe algorithm. Unfortunately, the algorithm works incorrectly if any map except 1:1 is used, so the information in nxspe file is incorrect. In addition to that, distance from sample to detectors is needed for number of algorithms, using spe and nxspe data
Needed: 1) Save sample-to-detectors distances in nxspe file. 2) savenxspe algorithm needs requesting par of phx file (the files with proper angular detectors positions defined), if any map except 1:1 is specified. This will allow to modify this algorithm, adding sub-algorithms to identify proper angular positions and sizes of combined (mapped) detectors for different combinations of instruments and maps in a future. When all these sub-algorithms are available, a phx or par files would be obsolete.
Change History
comment:2 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 28 to Iteration 29
Bulk move of tickets at the end of iteration 28
comment:3 Changed 9 years ago by Alex Buts
- Status changed from new to assigned
- Owner changed from Stuart Campbell to Alex Buts
comment:10 Changed 9 years ago by Alex Buts
comment:11 Changed 9 years ago by Alex Buts
comment:12 Changed 9 years ago by Alex Buts
comment:13 Changed 9 years ago by Alex Buts
comment:14 Changed 9 years ago by Alex Buts
comment:15 Changed 9 years ago by Alex Buts
comment:16 Changed 9 years ago by Alex Buts
comment:17 Changed 9 years ago by Alex Buts
comment:18 Changed 9 years ago by Alex Buts
comment:19 Changed 9 years ago by Alex Buts
comment:20 Changed 9 years ago by Alex Buts
comment:21 Changed 9 years ago by Alex Buts
comment:22 Changed 9 years ago by Alex Buts
comment:23 Changed 9 years ago by Alex Buts
comment:24 Changed 9 years ago by Alex Buts
comment:25 Changed 9 years ago by Alex Buts
comment:26 Changed 9 years ago by Alex Buts
comment:27 Changed 9 years ago by Alex Buts
comment:28 Changed 9 years ago by Alex Buts
comment:29 Changed 9 years ago by Alex Buts
comment:30 Changed 9 years ago by Alex Buts
comment:31 Changed 9 years ago by Alex Buts
comment:32 Changed 9 years ago by Alex Buts
comment:33 Changed 9 years ago by Alex Buts
comment:34 Changed 9 years ago by Russell Taylor
comment:35 Changed 9 years ago by Alex Buts
comment:36 Changed 9 years ago by Alex Buts
comment:37 Changed 9 years ago by Alex Buts
comment:38 Changed 9 years ago by Alex Buts
comment:39 Changed 9 years ago by Alex Buts
comment:40 Changed 9 years ago by Alex Buts
comment:41 Changed 9 years ago by Alex Buts
comment:42 Changed 9 years ago by Alex Buts
comment:43 Changed 9 years ago by Alex Buts
comment:44 Changed 9 years ago by Alex Buts
comment:45 Changed 9 years ago by Alex Buts
comment:46 Changed 9 years ago by Alex Buts
comment:47 Changed 9 years ago by Alex Buts
comment:48 Changed 9 years ago by Alex Buts
(In [12321]) refs #2745 final tests and conclusion; it should be it if everything works fine on real systems algorithm to calculate azimuthal width in cylindrical system has changed, which may be wrong for square detectors (and there should have 365% anyway) but may be reasonable for maps. refs #3127 SaveNXSPE modified to write NaN instead of -1e+30; Questionable but can be easy reverted
comment:49 Changed 9 years ago by Alex Buts
works satisfactory despite some annoyances, which can be fixed in within other tickets.
comment:51 Changed 9 years ago by Alex Buts
- Status changed from accepted to verify
- Resolution set to worksforme
works satisfactory despite some annoyances, which can be fixed in within other tickets.
comment:52 Changed 9 years ago by Alex Buts
comment:53 Changed 9 years ago by Alex Buts
comment:54 Changed 9 years ago by Alex Buts
- Status changed from verify to reopened
- Resolution worksforme deleted
comment:57 Changed 9 years ago by Alex Buts
- Status changed from accepted to verify
- Resolution set to fixed
comment:58 Changed 9 years ago by Alex Buts
comment:59 Changed 9 years ago by Alex Buts
comment:60 Changed 9 years ago by Alex Buts
comment:61 Changed 9 years ago by Alex Buts
comment:62 Changed 9 years ago by Alex Buts
comment:63 Changed 9 years ago by Alex Buts
comment:64 Changed 9 years ago by Alex Buts
comment:65 Changed 9 years ago by Alex Buts
comment:66 Changed 9 years ago by Alex Buts
comment:67 Changed 9 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:68 Changed 9 years ago by Andrei Savici
- Status changed from verifying to closed
It does not overwrite L2. Is it supposed to be this way?
comment:69 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 3592
Adding L2 covered in ticket #2826