Ticket #2762 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

BoxController: track box stats for a MDEventWorkspace

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Count how many boxes at each level of recursion as they get split. The call to count the boxes is slow when # of boxes is high.

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

(In [10551]) Refs #2762: Track MDBox statistics in BoxController (for better performance of another function).

comment:3 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [10575]) Fixes #2762: Track the number of boxes in the box controller.

comment:4 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:5 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to reopened
  • Resolution fixed deleted

BoxController::getAverageDepth() line 293 of BoxController.h. Runtime error via MDEventsTest and Paraview plugins.

total += double(depth * m_numMDBoxes[depth]) * (maxNumberOfFinestBoxes / m_maxNumMDBoxes[depth]) ;

seems that m_maxNumMDBoxes has size 6, and at some point depth == 6.

comment:6 Changed 9 years ago by Janik Zikovsky

  • Milestone changed from Iteration 28 to Iteration 29

Will look into during iteration 29.

comment:7 Changed 9 years ago by Janik Zikovsky

  • Status changed from reopened to verify
  • Resolution set to fixed

(In [11203]) Fixes #2762: Fixed the BoxController stats not being initialized correctly, causing NaN and errors when looking at MDEventWorkspace stats.

comment:8 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying

comment:9 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

BoxController has test set covering this functionality. All passing.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3609

Note: See TracTickets for help on using tickets.