Ticket #2780 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

There is no SANS phi masking

Reported by: Steve Williams Owned by: Steve Williams
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

The Limit Phi controls in the SANS GUI were not affecting the results because an invalid string was being passed to MaskDetectorsInShape. Ensure that the string is valid and a new masking system test is added.

Change History

comment:1 Changed 10 years ago by Steve Williams

  • Status changed from new to accepted

The location of the controls maybe moved to the Masking tab, see comments added below

comment:2 Changed 10 years ago by Steve Williams

(In [10615]) In SANS masking fix problem with invalid xml for cylinders and planes re #2780

comment:3 Changed 10 years ago by Steve Williams

(In [10644]) In SANS masking fix problem with invalid xml for cylinders re #2780

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:5 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:6 Changed 9 years ago by Steve Williams

In [13376]:

Fixed another case where phi masking was working and added some tests re #2780

comment:7 Changed 9 years ago by Steve Williams

In [13378]:

more tests for phi masking re #2780

comment:8 Changed 9 years ago by Steve Williams

In [13380]:

more tests for phi masking re #2780

comment:9 Changed 9 years ago by Steve Williams

In [13383]:

more tests for phi masking re #2780

comment:10 Changed 9 years ago by Steve Williams

In [13384]:

more tests for phi masking re #2780

comment:11 Changed 9 years ago by Steve Williams

In [13427]:

Remove some code duplication from phi masking re #2780

comment:12 Changed 9 years ago by Steve Williams

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:13 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:14 Changed 9 years ago by Anders Markvardsen

  • Status changed from verifying to closed

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3627

Note: See TracTickets for help on using tickets.