Ticket #2789 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Build issues due to incorrect Crystal dependencies

Reported by: Martyn Gigg Owned by: Andrei Savici
Priority: major Milestone: Iteration 28
Component: Mantid Keywords:
Cc: martyn.gigg@…, scu@… Blocked By:
Blocking: Tester: Janik Zikovsky

Description

The Crystal library is now a dependency for other libraries. It should be a plugin. It is causing build issues and this needs to be rectified.

Change History

comment:1 Changed 10 years ago by Martyn Gigg

(In [10653]) Refs #2789. Temporarily remove crystal python exports until they are refactored correctly. They are causing many problems with builds and installers.

comment:2 Changed 10 years ago by Martyn Gigg

(In [10654]) Remove another reference. Refs #2789

comment:3 Changed 10 years ago by Martyn Gigg

  • Cc martyn.gigg@… added; martyn.gigg@… removed

comment:4 Changed 10 years ago by Andrei Savici

  • Status changed from new to accepted

comment:5 Changed 10 years ago by Martyn Gigg

(In [10655]) Missed a reference to crystal. Refs #2789

comment:6 Changed 10 years ago by Stuart Campbell

  • Cc scu@… added

comment:7 Changed 10 years ago by Andrei Savici

(In [10665]) Moved UnitCell class to Geometry/Crystal. Refs#829 and #2789

comment:8 Changed 10 years ago by Andrei Savici

(In [10668]) Deleted UnitCell from Crystal. Refs #829 and #2789

comment:9 Changed 9 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [10754]) Removed last file related to UnitCell in Framework/Crystal. Fixes #2789

comment:10 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:11 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

True, you can remove Crystal from the build with no problems.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3636

Note: See TracTickets for help on using tickets.