Iteration 28: Compiler Warnings

[Stuart Campbell]

General ticket for compiler warnings for iteration 28

[Stuart Campbell]

(In [10748]) remove unused variables. refs #2818

[Stuart Campbell]

(In [10755]) remove compiler warnings. refs #2818

[Stuart Campbell]

(In [10756]) remove compiler warnings. refs #2818

[Stuart Campbell]

(In [10760]) initialise variables. refs #2818

[Stuart Campbell]

(In [10761]) fix signed/unsigned comparison. refs #2818

[Stuart Campbell]

(In [10762]) remove compiler warnings. refs #2818

[Stuart Campbell]

(In [10763]) fix signed/unsigned comparison. refs #2818

[Stuart Campbell]

(In [10764]) remove some compiler warnings. refs #2818

[Stuart Campbell]

(In [10942]) Remove compiler warnings for Nexus on Linux. refs #2818

[Stuart Campbell]

(In [10943]) Remove compiler warnings for DataHandling (well LoadDAE) on Linux. refs #2818

[Stuart Campbell]

(In [10944]) Remove compiler warnings for NexusTest on Linux. refs #2818

[Stuart Campbell]

(In [10945]) Remove compiler warnings for DataHandlingTest on Linux. refs #2818

[Stuart Campbell]

(In [10946]) Fix build. refs #2818

[Martyn Gigg]

(In [10955]) Refs #2818. First round of commits for warning clearance on MSVC. There was a macro clash with muParser so I added a wrapper and replaced all includes with this one.

[Owen Arnold]

(In [10956]) re #2818 gcc warnings hunt.

[Anders Markvardsen]

(In [10957]) Notice what looks like ga ga in Atom.h

Declare attribute:

const NeutronAtom& neutron;

but construct it using from temporary local variable:

const NeutronAtom getNeutronNoExceptions(const uint16_t z, const uint16_t a) {

try {

return getNeutronAtom(z, a);

} catch (std::runtime_error & ) {

return NeutronAtom(z, a,

NAN, NAN, NAN, NAN, NAN, NAN, NAN, NAN); set to junk value

}

}

Atom::Atom(const string& symbol, const uint16_t z, const uint16_t a,

const double abundance, const double mass, const double density) : symbol(symbol), z_number(z), a_number(a), abundance(abundance), mass(mass), mass_density(density), number_density(density * N_A / mass), neutron(getNeutronNoExceptions(z, a))

{ }

Changed local attribute 'neutron' to be NeutronAtom instead of NeutronAtom&.

re #2818

[Martyn Gigg]

(In [10958]) Refs #2818. Add a few warning options on gcc as there are some that show up on Windows that are useful, in particular conversions that lead to loss of data.

[Martyn Gigg]

(In [10959]) Refs #2818. A couple of those gcc flags aren't valid for C++.

[Owen Arnold]

(In [10960]) re #2818 gcc warnings hunt. Mostly unused argument warnings or init arg ordering.

[Anders Markvardsen]

(In [10962]) Remove 90 something percent of Kernel warnings. re #2818

[Owen Arnold]

(In [10963]) re #2818 gcc warnings hunt. Minor change to fix Vates warning while still using gcc.

[Roman Tolchenov]

(In [10964]) Added the XIntegrationControl ( re #2134 ) and removed a few compiler warnings in MantidPlot ( re #2818 ).

[Owen Arnold]

(In [10965]) re #2818 VS warnings hunt. Fix MDDataObject build for windows.

[Martyn Gigg]

(In [10966]) Refs #2818. MSVC warnings clearance for MDGeometry + related.

[Owen Arnold]

(In [10967]) re #2818 Fix broken test and fix warning.

[Martyn Gigg]

(In [10968]) Refs #2818. Clear a further large stack of warnings from Geometry.

[Roman Tolchenov]

(In [10969]) More warnings cleared from MantidPlot. re #2818

[Owen Arnold]

(In [10970]) re #2818 Remove all warnings possible from VATES project under windows after geometry-level type changes.

[Roman Tolchenov]

(In [10971]) The build server wasn't happy. re #2818

[Owen Arnold]

(In [10972]) re #2818 Remove from MDDataObjects/MDDataAlgorithms under windows. some use of static_casts required. Should refactor out later.

[Owen Arnold]

(In [10973]) re #2818 Want to verify things work in MDDataObjects.

[Martyn Gigg]

(In [10974]) Refs #2818. Geometry (and tests) now compile cleanly on MSVC. About to lose the will to live...

[Martyn Gigg]

(In [10975]) Refs #2818. Clear Python API compiler warnings on MSVC. Had to define a global boost/python.hpp wrapper as alot of warnings came out of there. Not 100% happy but can't think of another way.

[Martyn Gigg]

(In [10976]) Refs #2818. Missed a new file.

[Martyn Gigg]

(In [10977]) Refs #2818. Fix linux include.

[Steve Williams]

(In [10978]) Cleared the matlab compiler warnings re #2818

[Steve Williams]

(In [10979]) Partial clearing of Datahandling warnings, many remain re #2818

[Martyn Gigg]

(In [10985]) Remove the final few warnings from Kernel on Linux. Re #2818

[Martyn Gigg]

(In [10986]) Fix Mac. Re #2818

[Martyn Gigg]

(In [10987]) Fix DateAndTime test. Re #2818

[Steve Williams]

(In [10988]) Last matlab compiler warnings from mwdebg.c re #2818

[Anders Markvardsen]

(In [10989]) Remove last Kernel warnings. re #2818

[Martyn Gigg]

(In [10990]) Refs #2818. Cleared gcc warnings for Geometry. Some should have been picked up with MSVC, not sure why they weren't. Anyhow, back to some real work...

[Martyn Gigg]

(In [10991]) Refs #2818. Missed a file deletion.

[Martyn Gigg]

(In [10993]) Refs #2818. Easy win, 85 warnings gone.

[Martyn Gigg]

(In [10994]) Refs #2818. Better fix for the future. Now the generated files won't need changing at all.

[Martyn Gigg]

(In [10995]) Refs #2818. Missed 2 file adds.

[Roman Tolchenov]

(In [11002]) Cleared a few linux warnings. re #2818

[Steve Williams]

(In [11005]) Cleared all the Datahandling warnings on my machine re #2818

[Roman Tolchenov]

(In [11019]) More warnings cleared from MantidPlot. re #2818

[Martyn Gigg]

(In [11036]) Refs #2818. Stop warnings from the Qt libraries headers from pervading our code.

[Martyn Gigg]

(In [11041]) Fix the python script generation for the dynamic Load algorithm. Fixes #2465. Also cleared a few more warnings. Refs #2818

[Janik Zikovsky]

(In [11065]) - Refs #2835: Added a MDDimensionStats object that calculates mean and approximate variance of positions.

• Refs #2835: Implemented a binary-tree style splitting for MDEventWorkspaces (MDSplitBox) as an experiment to replace MDGridBox.
• Added Utils::NestedForLoop routines.
• Refs #2711: Improved MDEventWorkspace binning speed by approximately 20 through better scheduling. Memory use is also much lower.
• Refs #2818: Fixed compiler warnings for MDEvents and MDEventsTest (as of last ~Monday with fewer warnings flags).
• More flags added to class_maker.py

[Janik Zikovsky]

(In [11066]) Refs #2818: Fixed some of the new warnings in MDEvents

[Janik Zikovsky]

(In [11067]) Refs #2818: Fixed all remaining compiler warnings in MDEvents.

[Janik Zikovsky]

(In [11068]) Refs #2818: Fixed compiler warning on Linus for MDAlgorithms.

[Nick Draper]

Bulk move of tickets at the end of iteration 28

[Peter Peterson]

(In [11131]) Frixes #2502. Refs #2818.

[Stuart Campbell]

Closing for end of iteration.

[Stuart Campbell]

This ticket has been transferred to github issue ​3665