Ticket #2838 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Create a Peak object (for PeaksWorkspace)

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 28
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description


Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

(In [10900]) Refs #2838: Start of a Peak object.

comment:3 Changed 9 years ago by Janik Zikovsky

(In [10906]) Refs #2838: GetXY for detector ID added to Rectangular detector, and used in Peak object.

comment:4 Changed 9 years ago by Janik Zikovsky

(In [10926]) Refs #2838: Peak object is pretty complete; some of the conversions to DSpacing and such should be checked to be sure. Tests are in place.

comment:5 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 9 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:7 Changed 9 years ago by Andrei Savici

Minor defects and enhancements needed

  1. Add a constructor that allows to set hkl and goniometer rotation matrix.Also initialize the rotation matrix to unity if not set otherwise
  2. In getWavelength check E_initial=E_final
  3. In getTOF, you should not assume elastic scattering. tof=d_samp_source/v_initial+d_sample_detector/v_final
  4. Point 3 is especially important for getting qlab
  5. In QSampleFrame you need to multiply with the inverse (or the transpose if you want to. they are the same for a rotation matrix)

comment:8 Changed 9 years ago by Andrei Savici

  • Status changed from verifying to closed

Defects will be fixed in #2870

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3685

Note: See TracTickets for help on using tickets.