Ticket #2856 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

SANSRunWindow interferes with Facility selection

Reported by: Mathieu Doucet Owned by: Anders Markvardsen
Priority: major Milestone: Release 2.1
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

SANSRunWindow seems to hook up to Facility selection but doesn't behave well when the facility is changed.

  • Starting SANSRunWindow when HFIR is selected as the facility generates python errors.
  • Switching facility at any time after SANSRunWindow has been opened (regardless of whether it is still open or not) will generate python errors.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:2 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:3 Changed 9 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Anders Markvardsen

Discuss with Nick / Martin before starting

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:5 Changed 9 years ago by Anders Markvardsen

  • Status changed from assigned to accepted

When HFIR is selected and ISIS SANS opened in MantidPlot the message is: "Only the ISIS facility is supported by this interface blah blah"

Same message is displayed when switching facility after ISIS SANS has been opened

comment:6 Changed 9 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to worksforme

comment:7 Changed 9 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:8 Changed 9 years ago by Nick Draper

  • Status changed from verifying to reopened
  • Resolution worksforme deleted
  • Milestone changed from Iteration 32 to Iteration 33

Yes the warning message is in place, but:

  1. You do get python error messages after the warning message when changing to HFIR (with the window open)
  2. You get some unpleasant errors changing back to ISIS, if your default instrument is for example ALF. An Error caught by the last chance error handler (terminate/continue), and then the combobox to choose another instrument (on the SANS dialog) only contains ALF. you have to close and reopen the interface.

comment:9 Changed 8 years ago by Anders Markvardsen

Fixed: SANSRunWindow interferes with Facility selection. re #2856

Changeset: aa31a12210e7f7ec6d26cb77133e3e1ad9a43eaf

comment:10 Changed 8 years ago by Anders Markvardsen

  • Status changed from reopened to accepted

comment:11 Changed 8 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:12 Changed 8 years ago by Anders Markvardsen

Fixed: SANSRunWindow interferes with Facility selection. re #2856

Changeset: aa31a12210e7f7ec6d26cb77133e3e1ad9a43eaf

comment:13 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester changed from Nick Draper to Michael Reuter

comment:14 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

I don't see anymore error message when switching to HFIR from ISIS with the interface open. I also don't get any errors when switching back to ISIS with ALF as default whether or not the window is open. This looks like it's fixed.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3703

Note: See TracTickets for help on using tickets.