Ticket #2918 (closed: fixed)
Visualisation of 1d, 2d and 3d IMDWorkspaces
Reported by: | Owen Arnold | Owned by: | Owen Arnold |
---|---|---|---|
Priority: | major | Milestone: | Iteration 29 |
Component: | VATES | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Janik Zikovsky |
Description
The current implementation expects the IMDWorkspace to present mappings for 4 dimensions (x, y, z, t). In the case that these mappings are not required, or when the actual dimensionality is less than 4, we currently have no way of providing the visualisation.
In addition to providing additional versions of vtkDataSetFactory for the 1D, 2D and 3D cases, we should also implement a Chain Of Responsibility pattern starting with the 4D case and cascading down to the 1D case. This way the vtkDataSetFactories will be self managing, and delegate to other chained factories if they are unable to render the IMDWorkspaces themselves.
Change History
comment:9 Changed 9 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
Done. Individual unit tests for each type of vtkDataSet generated from a IMDWorkspace in VatesAPITests.
comment:10 Changed 9 years ago by Janik Zikovsky
- Status changed from verify to verifying
- Tester set to Janik Zikovsky
comment:11 Changed 9 years ago by Janik Zikovsky
- Status changed from verifying to reopened
- Resolution fixed deleted
1,2,3 dimensions work, but you can get a crash if you do this:
- Load the CNCS event nxs file.
- Check "integrated" on all 3 dimensions (go down to 0d). I know this is silly :)
- Click apply:
BinToMDHistoWorkspace-[Notice] BinToMDHistoWorkspace started BinToMDHistoWorkspace-[Information] Algorithm: BinToMDHistoWorkspace v1 BinToMDHistoWorkspace-[Information] Parameters: BinToMDHistoWorkspace-[Information] Name: InputWorkspace, Value: eventWsId, Default?: No, Direction: InOut BinToMDHistoWorkspace-[Information] Name: DimX, Value: , Default?: Yes, Direction: Input BinToMDHistoWorkspace-[Information] Name: DimY, Value: , Default?: Yes, Direction: Input BinToMDHistoWorkspace-[Information] Name: DimZ, Value: , Default?: Yes, Direction: Input BinToMDHistoWorkspace-[Information] Name: DimT, Value: , Default?: Yes, Direction: Input BinToMDHistoWorkspace-[Information] Name: ImplicitFunctionXML, Value: , Default?: Yes, Direction: Input BinToMDHistoWorkspace-[Information] Name: OutputWorkspace, Value: histogramWsId, Default?: No, Direction: Output BinToMDHistoWorkspace-[Error] Logic Error in execution of algorithm BinToMDHistoWorkspace BinToMDHistoWorkspace-[Error] 0 valid dimensions were given to the MDHistoWorkspace constructor!
and then a crash.
comment:12 Changed 9 years ago by Owen Arnold
- Status changed from reopened to accepted
I take the view that If it can be done users will eventually try it. Better to fix now.
comment:13 Changed 9 years ago by Owen Arnold
comment:14 Changed 9 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
comment:16 Changed 9 years ago by Janik Zikovsky
- Status changed from verifying to closed
0d is not allowed.
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 3765