Ticket #2930 (closed: invalid)

Opened 9 years ago

Last modified 5 years ago

Remove callback from Python into MantidUI when executing algorithms

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: doucetm@… Blocked By:
Blocking: Tester: Nick Draper

Description

Currently when executing an algorithm asynchronously from Python we call back to the MantidUI object and perform the execution there since we can't pass the algorithm object across the sip defined Python (there's a problem with doing it for the abstract IAlgorithm class). This has the problem that we have to assume that the last object added to the manager's stack is the correct one.

We should expose the executeAsync and Poco::ActiveResult<bool> classes to Python and handle this all in Python. The PyQt4.QtCore.QCoreApplication instancee can be used to ensure that the application still polls for events

Change History

comment:1 Changed 9 years ago by Martyn Gigg

Some of this got done under #2883

comment:2 Changed 9 years ago by Mathieu Doucet

  • Cc doucetm@… added

comment:3 Changed 9 years ago by Martyn Gigg

(In [11257]) Refs #2930. Update the generic load dialog to remove reference to non-existent callback function.

comment:4 Changed 9 years ago by Martyn Gigg

(In [11261]) Refs #2930. Fix the LoadDialog python command which had stopped working and simplify the whole thing regarding the generating mantidsimple. Now it simply generates all of the functions, there is no longer a gui flag. At runtime it checks whether it can use them or not.

comment:5 Changed 9 years ago by Martyn Gigg

(In [11262]) Refs #2930. Fix the tests.

comment:6 Changed 9 years ago by Martyn Gigg

  • Status changed from new to accepted

Still there for the dialogs but these are inherently blocking so I'm not as woried about them.

comment:7 Changed 9 years ago by Martyn Gigg

(In [11282]) Add the callback from Python to MantidPlot for executing algorithms until I understand the crashes that the changes made happen. Re #2930

comment:8 Changed 9 years ago by Martyn Gigg

(In [11287]) Refs #2930. Urgent fix for Windows that prevents MantidPlot from starting.

comment:9 Changed 9 years ago by Martyn Gigg

(In [11310]) Refs #2930. Fix running Python algorithms from the algorithm dock in MantidPlot

comment:10 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:11 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:12 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:13 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to invalid

See #5006. This will get covered properly there.

comment:14 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

invalid approves

comment:15 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

I meant approved

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3777

Note: See TracTickets for help on using tickets.