Ticket #295 (closed: fixed)

Opened 12 years ago

Last modified 5 years ago

Accurate shape description backscattering banks

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: major Milestone: Iteration 14
Component: Keywords:
Cc: nick.draper@… Blocked By:
Blocking: Tester:

Description

Describe the shape of the backscattering detector banks of HRPD and GEM using curved geometric objects (none box-shaped objects).

Change History

comment:1 Changed 12 years ago by Anders Markvardsen

(In [1612]) Added additional unit tests to test HRP_Defintion.xml to try to understand why the curved shape object generated by the XML tag <slice-of-cylinder-ring> does not show up correctly in the MantidPlot. These tests use the isValid() method and they indicate strongly that the shape generated by <slice-of-cylinder-ring> is what you would expect it to be. To further investigating this an additional testing Instrument Definition file, IDF_for_unit_testing2.xml, has been added. The unit tests on this xml file support the previous finding.... Refs #295.

comment:2 Changed 12 years ago by Anders Markvardsen

(In [1630]) Algebra string in IDF now allows shape IDs to be defined in arbitrary order. Refs #295

comment:3 Changed 12 years ago by Anders Markvardsen

(In [1638]) Added new IDF file for unit testing. This IDF (IDF_for_unit_testing2.xml) has defined a monitor shape equal to a cylinder ring (a simpler shape than the <slice-of-cylinder-ring> shape). The isValid() unit tests on this shape strongly indicates that it is a cylinder ring, however the picture you get with MantidPlot is something different. Refs #295.

comment:4 Changed 12 years ago by Anders Markvardsen

(In [1645]) Put in C++ code to define bounding-box in IDF but no unit test for this added yet. Refs #295.

comment:5 Changed 12 years ago by Anders Markvardsen

(In [1648]) Put <bounding-box> into use in IDF_for_unit_testing2.xml, however still the cylinder ring defined in type named "monitor-cylinder-ring-shape" in that IDF does not display properly. Refs #295.

comment:6 Changed 12 years ago by Anders Markvardsen

(In [1653]) With <bounding-box> XML tags added HRP_Definition.xml the back scattering data bank appears and possibly looks pretty close to what is expected! Refs #295.

comment:7 Changed 12 years ago by Anders Markvardsen

(In [1657]) Added doc for XML tag <slice-of-cylinder-ring> to "Geometry Objects and xml tags.doc". Refs #295.

comment:8 Changed 12 years ago by Anders Markvardsen

(In [1668]) Allow a component not to face a default facing component but still be rotated about z-axis. Refs #295.

comment:9 Changed 12 years ago by Anders Markvardsen

(In [1710]) Added curved shape description to forward detector bank for GEM. Grouped bank 2 to 5 detectors into east and west groups. Refs #295.

comment:10 Changed 12 years ago by Anders Markvardsen

(In [1723]) Full curved detector description of GEM! Refs #295.

comment:11 Changed 12 years ago by Anders Markvardsen

(In [1725]) Update of gem tests. Refs #295.

comment:12 Changed 12 years ago by Anders Markvardsen

  • Status changed from new to closed
  • Resolution set to fixed

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 1143

Note: See TracTickets for help on using tickets.