In MuonAnalysis Fitting tab change startX to Start (us) and endX to Finish (us) and a few other changes.

[Anders Markvardsen]

See attached picture for proposed layout of fitting tab.

Note before this ticket can be completed ticket #2972 needs to have been completed.

[Anders Markvardsen]

Comment from Steve about Fit raw data or bunch data:

If no bunching (binning) has been defined elsewhere (in plot options?) then this menu probably wouldn’t have the option to fit ‘bunch data’. Other possibilities are to place a ‘Fit bunched data’ tick box next to the bunching instruction in plot options, in this case, you’d still need a line in the analysis tab to report what the program is doing, or to define a separate bunching at this point for data fitting. I guess I prefer the first of the ‘other options’, but not too strongly. We seem to have called ‘bunching’ ‘binning’ in the plot options, so we’ll need to be consistent.

[Anders Markvardsen]

More comments from Steve:

1. We’ve made a deal about hiding Workspaces while using the muon interface. On the other hand, it might be good to know which Workspace the program is using. Perhaps the Workspaces should be reported as read only, the minimizer definable.

2. Units are needed on the startx and endx values (the use of tooltips for the fit parameters sounds a very good idea).

[Anders Markvardsen]

Most recent comment from Muon guys on startX and endX

We had a bit of a debate about using ‘time’ or ‘x’ (‘x’ could be ‘time’ or ‘freq’ was the discussion). However, we seem to have specialised in other parts of the interface on analysing the time domain, so perhaps keep it identical with the ‘plot options’ … ‘Start at (us)’, etc

[Nick Draper]

"New" tickets moved at the code freeze of iteration 29

[Anders Markvardsen]

Some the stuff in this ticket has been fixed, but we have a chat about the rest when u get back

[Nick Draper]

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

[Robert Whitley]

Talking to the scientists they have asked for a different layout for the fit property browser within the data analysis tab. The layout is as such.

Functions

(as is)

Data

Workspace

Workspace index

Start (us)

Finish (us)

Settings

Minimizer

Plot Difference

Fit to binned data? (yes/no, default ‘no’ or perhaps a check box)

[Robert Whitley]

In [14842]:

Refs #2974. Changed the layout of the FitPropertyBrowser in the muon analysis interface and changed startX to Start (μs) and a similar thing for endX. I've also changed the data option to a more sensibly named "Fit to binned data?" one. This is a check box option and is defaulted to false.

[Martyn Gigg]

Confirmed that the fields have different names on the Muon tab. However, I'm not convinced what has been implemented is the best long-term solution as it relies on having custom code for the Muon (and possibly others in the future) group in the general interface.

A better solution may be to specialise the FitPropertyBrowser and set the appropriate differences in this class.

[Stuart Campbell]

This ticket has been transferred to github issue ​3821