Ticket #2998 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

DiffractionFocussing2: speed up for large instruments.

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By: #2999
Blocking: Tester: Vickie Lynch

Description

Profiling shows that 66% of the time spent focussing an instrument like SNAP are spent in getDetector(workspaceIndex).

29% are spent in ValidateSpectrumInGroup().

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

  • Blocked By 2999 added

comment:3 Changed 9 years ago by Janik Zikovsky

(In [11367]) Refs #2998: Added a performance test for DiffractionFocussing2, with 4 ways to focus event data.

comment:4 Changed 9 years ago by Janik Zikovsky

(In [11369]) Refs #2998: Fix performance test and add a method that could parallelize better when focussing to a single group.

comment:5 Changed 9 years ago by Janik Zikovsky

(In [11371]) Refs #2998: SNAP focussing is about 3 times faster (4 seconds instead of 13) in the special case of focussing to a single group in an Eventworkspace.

comment:6 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

The slowest step in DiffractionEventCalibrateDetectors is now ConvertUnits.

comment:7 Changed 9 years ago by Janik Zikovsky

(In [11384]) Refs #2998, #839: Made DiffractionFocussing2TestPerformance a lot faster.

comment:8 Changed 9 years ago by Martyn Gigg

(In [11398]) Refs #2998. Disable the DiffractionFocussing2 performance test as its constructor is run before each individual unit test in algorithms meaning each takes about 40 seconds (atleast on the ISIS Windows 32-bit build server)

comment:9 Changed 9 years ago by Janik Zikovsky

(In [11402]) Refs #2998: Fixed issue with DiffractionFocussing2TestPerformance where the constructor was called for every single run.

comment:10 Changed 9 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:11 Changed 9 years ago by Vickie Lynch

  • Status changed from verifying to closed

DiffractionFocussing is now much faster for SNAP.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3845

Note: See TracTickets for help on using tickets.