Ticket #3005 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

IQTransform - Should ensure X-data is in the right direction

Reported by: Michael Whitty Owned by: Arturs Bekasovs
Priority: major Milestone: Release 2.6
Component: Framework Keywords: Student,First
Cc: Blocked By:
Blocking: Tester: Jay Rainey

Description


Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:2 Changed 9 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Anyone

X data must increase left to right

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:7 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:8 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:9 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:10 Changed 7 years ago by Nick Draper

  • Keywords Student added

Create an Incrementing Axis validator, make use of it then advertise it to others.

ConvertAxisByFormula would really benefit from this as a check after conversion.

comment:11 Changed 7 years ago by Martyn Gigg

  • Keywords Student,First added; Student removed

comment:12 Changed 7 years ago by Nick Draper

  • Owner changed from Anyone to Arturs Bekasovs

comment:13 Changed 7 years ago by Arturs Bekasovs

  • Status changed from assigned to accepted

comment:14 Changed 7 years ago by Arturs Bekasovs

Added a new validator class to perform the check

Refs #3005

Changeset: 6b2438c31019c96f507f18a6648978b1357dc72d

comment:15 Changed 7 years ago by Arturs Bekasovs

Added a test for the new validator class

Refs #3005

Changeset: d97cc5eb86c57a4147f23bab01b3343607633d13

comment:16 Changed 7 years ago by Arturs Bekasovs

Added a new validation to the IQTransform

Refs #3005

Changeset: 5a57508d5ed8fbb98efbcbcae80665ecbb8e4d64

comment:17 Changed 7 years ago by Arturs Bekasovs

Used Axis object instead of the raw X data

Refs #3005

Changeset: 6540c8165bb778e442c13964fd5a5f7667c687d1

comment:18 Changed 7 years ago by Arturs Bekasovs

Added a check for a proper axis order to the ConvertAxisByFormula

Refs #3005

Changeset: f6383e0ce77183f7ec39c63a8f680515caeaf1fe

comment:19 Changed 7 years ago by Arturs Bekasovs

Make the validator account for workspaces with single X value

Refs #3005

Changeset: e6a3f3efc6840836ba7fb340eeca12aeb6959c97

comment:20 Changed 7 years ago by Arturs Bekasovs

  • Status changed from accepted to verify
  • Resolution set to fixed

Branch: feature/3005_increasing_axis

Tester: First, create 2 workspaces which are usable by IQTransform, using the following script: 

dataX = [1,2,3,4,5,6]
dataY = [1,2,3,4,5]

ws1 = CreateWorkspace(DataX=dataX, DataY=dataY, UnitX="MomentumTransfer",Distribution=True)
ws2 = CreateWorkspace(DataX=dataX, DataY=dataY, UnitX="MomentumTransfer",Distribution=True)

Check that both of them are usable by SANS/IQTransform algorithm (we can select them from a drop-down list). Then transform one of them using Transforms/Axes/ConvertAxisByFormula by putting say ws1 as input and output workspace and "7-X" as formula. Notice the warning produced by ConvertAxisByFormula. Now check that IQTransform accepts the ws2 workspace, and not the converted ws1.

Last edited 7 years ago by Arturs Bekasovs (previous) (diff)

comment:21 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:22 Changed 7 years ago by Jay Rainey

Testing

  • Testing on Ubuntu 12.4.
  • Tested using transform methods, and works as expected. Produces the appropriate error when ConvertAxisByFormula is used.
  • IQTransform works correctly (e.g. only accepts data that goes from left to right).
  • No compiler warnings were present.

Code review

  • No visible bugs.
  • Clean, and well written code.
  • Consistent code abiding by standards.

comment:23 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

comment:24 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:25 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3852

Note: See TracTickets for help on using tickets.