Ticket #3008 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Make more of the code use sized integers

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By: #3020, #3046
Blocking: Tester: Martyn Gigg

Description

Blame it all on me

Change History

comment:1 Changed 9 years ago by Peter Peterson

  • Owner set to Peter Peterson
  • Status changed from new to accepted

comment:2 Changed 9 years ago by Peter Peterson

(In [11410]) Refs #3008.

comment:3 Changed 9 years ago by Peter Peterson

(In [11412]) Refs #3008.

comment:4 Changed 9 years ago by Peter Peterson

(In [11413]) Refs #3008.

comment:5 Changed 9 years ago by Peter Peterson

(In [11414]) Refs #3008.

comment:6 Changed 9 years ago by Janik Zikovsky

(In [11416]) Refs #3008: Fix for size_t for MDEvents

comment:7 Changed 9 years ago by Janik Zikovsky

(In [11417]) Fixes to APITest Refs #3008

comment:8 Changed 9 years ago by Janik Zikovsky

(In [11418]) REfs #3008: APITest almost all fixed.

comment:9 Changed 9 years ago by Janik Zikovsky

(In [11419]) APITest fully fixed. Refs #3008.

comment:10 Changed 9 years ago by Janik Zikovsky

(In [11420]) Refs #3008: Fix DataObjectsTest

comment:11 Changed 9 years ago by Janik Zikovsky

(In [11421]) Refs #3008: DataHandlingTest builds.

comment:12 Changed 9 years ago by Janik Zikovsky

(In [11422]) Refs #3008 AlgorithmsTest builds.

comment:13 Changed 9 years ago by Janik Zikovsky

(In [11423]) Refs #3008: Every test builds except ICAT

comment:14 Changed 9 years ago by Janik Zikovsky

(In [11424]) Refs #3008: ICatTest builds.

comment:15 Changed 9 years ago by Peter Peterson

(In [11425]) Refs #3008.

comment:16 Changed 9 years ago by Janik Zikovsky

(In [11427]) Refs #3008: Fix SpecialWorkspace2D test.

comment:17 Changed 9 years ago by Janik Zikovsky

(In [11428]) Refs #3008: Couple of missing size_t

comment:18 Changed 9 years ago by Peter Peterson

(In [11434]) Refs #3008.

comment:19 Changed 9 years ago by Janik Zikovsky

(In [11435]) Refs #3008: Fixed LoadInstrument

comment:20 Changed 9 years ago by Janik Zikovsky

(In [11436]) Refs #3008: Fixed /GetMaskedDetectorsTest.h

comment:21 Changed 9 years ago by Peter Peterson

(In [11437]) Added typedefs to make the code more understandable. Refs #3008.

comment:22 Changed 9 years ago by Janik Zikovsky

(In [11438]) Refs #3008: API builds

comment:23 Changed 9 years ago by Janik Zikovsky

(In [11439]) Refs #3008: Geometry builds

comment:24 Changed 9 years ago by Janik Zikovsky

(In [11440]) Refs #3008: Geometry builds

comment:25 Changed 9 years ago by Janik Zikovsky

(In [11441]) Refs #3008: DataObjects builds

comment:26 Changed 9 years ago by Russell Taylor

(In [11442]) Fix for Windows (in one place at least). Re #3008.

comment:27 Changed 9 years ago by Russell Taylor

(In [11443]) And another one. Re #3008.

comment:28 Changed 9 years ago by Janik Zikovsky

(In [11444]) Refs #3008: Working on DataHandling

comment:29 Changed 9 years ago by Janik Zikovsky

(In [11445]) Refs #3008: API builds. Others break.

comment:30 Changed 9 years ago by Russell Taylor

(In [11446]) Another one. Re #3008.

comment:31 Changed 9 years ago by Janik Zikovsky

(In [11447]) Refs #3008: Making progress ... towards getting carpal tunnel syndrome.

comment:32 Changed 9 years ago by Janik Zikovsky

(In [11448]) Refs #3008

comment:33 Changed 9 years ago by Janik Zikovsky

(In [11449]) Refs #3008: spectrum number and workspace index are not interchangeable terms.

comment:34 Changed 9 years ago by Janik Zikovsky

(In [11450]) Refs #3008: DataHandling finally builds.

comment:35 Changed 9 years ago by Janik Zikovsky

(In [11451]) Refs #3008: PythonAPI builds

comment:36 Changed 9 years ago by Janik Zikovsky

(In [11452]) Refs #3008: Working on Algorithms

comment:37 Changed 9 years ago by Janik Zikovsky

(In [11453]) Refs #3008: More algos

comment:38 Changed 9 years ago by Janik Zikovsky

(In [11454]) Refs #3008 more algos

comment:39 Changed 9 years ago by Janik Zikovsky

(In [11455]) Refs #3008: Algorithms builds.

comment:40 Changed 9 years ago by Janik Zikovsky

(In [11456]) Refs #3008: Framework all builds.

comment:41 Changed 9 years ago by Janik Zikovsky

(In [11457]) Refs #3008: MantidQT builds

comment:42 Changed 9 years ago by Janik Zikovsky

(In [11458]) Refs #3008: Everything builds!

comment:43 Changed 9 years ago by Janik Zikovsky

(In [11459]) Refs #3008: Well, not everything. The tests still don't build. But now APITest does.

comment:44 Changed 9 years ago by Janik Zikovsky

(In [11460]) Refs #3008: GeometryTest builds

comment:45 Changed 9 years ago by Janik Zikovsky

(In [11461]) Refs #3008: DataObjectTests builds

comment:46 Changed 9 years ago by Janik Zikovsky

(In [11462]) Refs #3008: Nexus test

comment:47 Changed 9 years ago by Janik Zikovsky

(In [11463]) Refs #3008: Boy there's a lot of repeated code in these tests

comment:48 Changed 9 years ago by Janik Zikovsky

(In [11464]) Refs #3008: DataHandling test builds

comment:49 Changed 9 years ago by Janik Zikovsky

(In [11465]) Refs #3008: AlgorithmsTest. tedious

comment:50 Changed 9 years ago by Janik Zikovsky

(In [11466]) Refs #3008: That's all of it! Now I don't expect the tests will actually all pass, but they build.

comment:51 Changed 9 years ago by Janik Zikovsky

(In [11467]) Refs #3008: Fix LoadInstrument - this should fix several tests.

comment:52 Changed 9 years ago by Martyn Gigg

(In [11468]) More size_t hoovering in MDDataObjects. Re #3008

comment:53 Changed 9 years ago by Martyn Gigg

(In [11469]) Fix for a very bad thing that happened with the size_t change. A loop was comparing for things being negative but unsigned types are never negative! There was even a compiler warning (granted there are a lot of those). Re #3008

comment:54 Changed 9 years ago by Martyn Gigg

(In [11472]) Fix for OpenMP loops that only accept signed types on windows. Re #3008

comment:55 Changed 9 years ago by Martyn Gigg

(In [11473]) Fix a few more algorithms tests. Re #3008

comment:56 Changed 9 years ago by Martyn Gigg

(In [11476]) Algorithms should pass now. Re #3008

comment:57 Changed 9 years ago by Martyn Gigg

(In [11478]) More test fixes. Re #3008

comment:58 Changed 9 years ago by Janik Zikovsky

(In [11479]) Refs #3008: CurveFitting changes to size_t.

comment:59 Changed 9 years ago by Martyn Gigg

(In [11480]) Fix DataHandling tests Re #3008

comment:60 Changed 9 years ago by Martyn Gigg

(In [11482]) Fix for the Mac build. Re #3008

comment:61 Changed 9 years ago by Janik Zikovsky

(In [11483]) Refs #3008: Added a line that seems to fix more CurveFitting tests.

comment:62 Changed 9 years ago by Peter Peterson

(In [11484]) Disabling test for the moment. Refs #3008.

comment:63 Changed 9 years ago by Peter Peterson

(In [11485]) Disabling test for the moment. Refs #3008.

comment:64 Changed 9 years ago by Janik Zikovsky

(In [11486]) Refs #3008: Reverted the size_t changes in CurveFitting. Tests seem to work on my machine

comment:65 Changed 9 years ago by Janik Zikovsky

(In [11487]) Refs #3008: fix for MantidPlot build

comment:66 Changed 9 years ago by Martyn Gigg

(In [11488]) Fix the mac build. The intel compiler defines size_t to unsigned long which doesn't match uint64_t that was exported. Re #3008

comment:67 Changed 9 years ago by Janik Zikovsky

(In [11489]) Refs #3008: Fixed Nexus test.

comment:68 Changed 9 years ago by Janik Zikovsky

(In [11490]) Refs #3008: PlotByPeakValue re-enabled test.

comment:69 Changed 9 years ago by Janik Zikovsky

(In [11500]) Refs #3008: OpenMP on windows. Also TimerTest reliability fix.

comment:70 Changed 9 years ago by Peter Peterson

  • Blocked By 3020 added

comment:71 Changed 9 years ago by Janik Zikovsky

(In [11502]) Refs #3008: Fixed VatesAPITest for size_t

comment:72 Changed 9 years ago by Janik Zikovsky

(In [11507]) Refs #3008: Fix a size_t test failure. Reduced code duplication. Fixes #2952: OffsetsWorkspaces etc. show less stuff in the dock.

comment:73 Changed 9 years ago by Janik Zikovsky

(In [11508]) Refs #3008: A go at fixing a win32 compile error.

comment:74 Changed 9 years ago by Janik Zikovsky

(In [11510]) Refs #3008: A go at fixing a win32 compile error.

comment:75 Changed 9 years ago by Janik Zikovsky

(In [11511]) Refs #3008: OpenMP windows

comment:76 Changed 9 years ago by Janik Zikovsky

(In [11512]) Refs #3008: A go at fixing a win32 compile error.

comment:77 Changed 9 years ago by Martyn Gigg

(In [11513]) Resurrect the 32-bit builds (not quite as simple as I first thought). Re #3008

comment:78 Changed 9 years ago by Martyn Gigg

(In [11514]) Resurrect the 32-bit builds. Re #3008

comment:79 Changed 9 years ago by Janik Zikovsky

(In [11515]) Refs #3008: Fix ICatTest. Made a macro in IPropertyManager.cpp to reduce duplicated code.

comment:80 Changed 9 years ago by Janik Zikovsky

(In [11517]) Refs #3008: OpenMP on win

comment:81 Changed 9 years ago by Martyn Gigg

(In [11518]) Fix remaining tests. on Mac. Re #3008

comment:82 Changed 9 years ago by Martyn Gigg

There is one remaining problem. We can no longer load some Nexus processed files containing events on 32-bit machines (windows/linux). Linux bad_allocs and Windows throws an length_error saying that vector<T> is too long.

comment:83 Changed 9 years ago by Martyn Gigg

(In [11520]) Fix LoadNexusProcessed for event files to read the correct axis dimension. Also made the dim? calls safer by checking the rank first. Re #3008

comment:84 Changed 9 years ago by Janik Zikovsky

(In [11535]) Refs #3008: Re-disablding SaveNexusProcessed testExecOnMuonXml that fails on win32

comment:85 Changed 9 years ago by Russell Taylor

Be aware that if any algorithm property's type has changed, yet a corresponding getProperty has not been updated, then this is a runtime, not a compile time failure.

Thus any place in the code (and I bet there aren't zero) where this is the case, and which is not reached by any of our automated testing, is something of a ticking bomb...

comment:86 Changed 9 years ago by Martyn Gigg

(In [11556]) Change nData to size_t for CurveFitting. Re #3008

comment:87 Changed 9 years ago by Martyn Gigg

(In [11557]) Fix UserAlgorithms. Re #3008

comment:88 Changed 9 years ago by Martyn Gigg

(In [11558]) Get things green (well blue) again... Re #3008

comment:89 Changed 9 years ago by Steve Williams

(In [11606]) One of the std::vector objects takes a negative flag value and can't be an unsigned type! Windows doesn't raise anything about this, saved by gcc re #3008

comment:90 Changed 9 years ago by Russell Taylor

(In [11626]) Should fix 32 bit windows, probably at the cost of a warning but I'm not on the right platform to take a chance. Re #3008.

comment:91 Changed 9 years ago by Russell Taylor

  • Blocked By 3046 added

comment:92 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:93 Changed 9 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed
  • Milestone changed from Iteration 30 to Iteration 29

It is as done is it is going to be.

comment:94 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:95 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to verify
  • Milestone changed from Iteration 29 to Iteration 30
  • Tester Michael Reuter deleted

This has to be moved to the next iteration since it is blocked by two other tickets that have had no work done on them and are not closed.

comment:96 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:97 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to closed

I'm sure there are still things that should technically be size_t or some sized types but I think there was enough done within this ticket.

The code + all tests pass so the code should be okay.

comment:98 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3855

Note: See TracTickets for help on using tickets.