Ticket #3008 (closed: fixed)
Make more of the code use sized integers
Reported by: | Peter Peterson | Owned by: | Peter Peterson |
---|---|---|---|
Priority: | major | Milestone: | Iteration 30 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | #3020, #3046 | |
Blocking: | Tester: | Martyn Gigg |
Description
Blame it all on me
Change History
comment:1 Changed 9 years ago by Peter Peterson
- Owner set to Peter Peterson
- Status changed from new to accepted
comment:10 Changed 9 years ago by Janik Zikovsky
comment:11 Changed 9 years ago by Janik Zikovsky
comment:12 Changed 9 years ago by Janik Zikovsky
comment:13 Changed 9 years ago by Janik Zikovsky
comment:14 Changed 9 years ago by Janik Zikovsky
comment:15 Changed 9 years ago by Peter Peterson
comment:16 Changed 9 years ago by Janik Zikovsky
comment:17 Changed 9 years ago by Janik Zikovsky
comment:18 Changed 9 years ago by Peter Peterson
comment:19 Changed 9 years ago by Janik Zikovsky
comment:20 Changed 9 years ago by Janik Zikovsky
comment:21 Changed 9 years ago by Peter Peterson
comment:22 Changed 9 years ago by Janik Zikovsky
comment:23 Changed 9 years ago by Janik Zikovsky
comment:24 Changed 9 years ago by Janik Zikovsky
comment:25 Changed 9 years ago by Janik Zikovsky
comment:26 Changed 9 years ago by Russell Taylor
comment:27 Changed 9 years ago by Russell Taylor
comment:28 Changed 9 years ago by Janik Zikovsky
comment:29 Changed 9 years ago by Janik Zikovsky
comment:30 Changed 9 years ago by Russell Taylor
comment:31 Changed 9 years ago by Janik Zikovsky
comment:32 Changed 9 years ago by Janik Zikovsky
comment:33 Changed 9 years ago by Janik Zikovsky
comment:34 Changed 9 years ago by Janik Zikovsky
comment:35 Changed 9 years ago by Janik Zikovsky
comment:36 Changed 9 years ago by Janik Zikovsky
comment:37 Changed 9 years ago by Janik Zikovsky
comment:38 Changed 9 years ago by Janik Zikovsky
comment:39 Changed 9 years ago by Janik Zikovsky
comment:40 Changed 9 years ago by Janik Zikovsky
comment:41 Changed 9 years ago by Janik Zikovsky
comment:42 Changed 9 years ago by Janik Zikovsky
comment:43 Changed 9 years ago by Janik Zikovsky
comment:44 Changed 9 years ago by Janik Zikovsky
comment:45 Changed 9 years ago by Janik Zikovsky
comment:46 Changed 9 years ago by Janik Zikovsky
comment:47 Changed 9 years ago by Janik Zikovsky
comment:48 Changed 9 years ago by Janik Zikovsky
comment:49 Changed 9 years ago by Janik Zikovsky
comment:50 Changed 9 years ago by Janik Zikovsky
comment:51 Changed 9 years ago by Janik Zikovsky
comment:52 Changed 9 years ago by Martyn Gigg
comment:53 Changed 9 years ago by Martyn Gigg
comment:54 Changed 9 years ago by Martyn Gigg
comment:55 Changed 9 years ago by Martyn Gigg
comment:56 Changed 9 years ago by Martyn Gigg
comment:57 Changed 9 years ago by Martyn Gigg
comment:58 Changed 9 years ago by Janik Zikovsky
comment:59 Changed 9 years ago by Martyn Gigg
comment:60 Changed 9 years ago by Martyn Gigg
comment:61 Changed 9 years ago by Janik Zikovsky
comment:62 Changed 9 years ago by Peter Peterson
comment:63 Changed 9 years ago by Peter Peterson
comment:64 Changed 9 years ago by Janik Zikovsky
comment:65 Changed 9 years ago by Janik Zikovsky
comment:66 Changed 9 years ago by Martyn Gigg
comment:67 Changed 9 years ago by Janik Zikovsky
comment:68 Changed 9 years ago by Janik Zikovsky
comment:69 Changed 9 years ago by Janik Zikovsky
comment:71 Changed 9 years ago by Janik Zikovsky
comment:72 Changed 9 years ago by Janik Zikovsky
comment:73 Changed 9 years ago by Janik Zikovsky
comment:74 Changed 9 years ago by Janik Zikovsky
comment:75 Changed 9 years ago by Janik Zikovsky
comment:76 Changed 9 years ago by Janik Zikovsky
comment:77 Changed 9 years ago by Martyn Gigg
comment:78 Changed 9 years ago by Martyn Gigg
comment:79 Changed 9 years ago by Janik Zikovsky
comment:80 Changed 9 years ago by Janik Zikovsky
comment:81 Changed 9 years ago by Martyn Gigg
comment:82 Changed 9 years ago by Martyn Gigg
There is one remaining problem. We can no longer load some Nexus processed files containing events on 32-bit machines (windows/linux). Linux bad_allocs and Windows throws an length_error saying that vector<T> is too long.
comment:83 Changed 9 years ago by Martyn Gigg
comment:84 Changed 9 years ago by Janik Zikovsky
comment:85 Changed 9 years ago by Russell Taylor
Be aware that if any algorithm property's type has changed, yet a corresponding getProperty has not been updated, then this is a runtime, not a compile time failure.
Thus any place in the code (and I bet there aren't zero) where this is the case, and which is not reached by any of our automated testing, is something of a ticking bomb...
comment:86 Changed 9 years ago by Martyn Gigg
comment:87 Changed 9 years ago by Martyn Gigg
comment:88 Changed 9 years ago by Martyn Gigg
comment:89 Changed 9 years ago by Steve Williams
comment:90 Changed 9 years ago by Russell Taylor
comment:92 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 29 to Iteration 30
Accepted and assigned tickets moved at iteration 29 code freeze
comment:93 Changed 9 years ago by Peter Peterson
- Status changed from accepted to verify
- Resolution set to fixed
- Milestone changed from Iteration 30 to Iteration 29
It is as done is it is going to be.
comment:94 Changed 9 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:95 Changed 9 years ago by Michael Reuter
- Status changed from verifying to verify
- Milestone changed from Iteration 29 to Iteration 30
- Tester Michael Reuter deleted
This has to be moved to the next iteration since it is blocked by two other tickets that have had no work done on them and are not closed.
comment:96 Changed 9 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:97 Changed 9 years ago by Martyn Gigg
- Status changed from verifying to closed
I'm sure there are still things that should technically be size_t or some sized types but I think there was enough done within this ticket.
The code + all tests pass so the code should be okay.
comment:98 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 3855