Ticket #3015 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

SANS reductions with different phi masking

Reported by: Steve Williams Owned by: Anders Markvardsen
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By: #2757
Blocking: Tester:

Description

Sectors are masked around the beam center to analyse non-circularly symmetric scattering patterns better. It would be useful if the GUI and user file could automatically set up reductions for multiple pairs of phi ranges. The syntax requires some thought.

The user will be able to write pairs of numbers into a box with a separator between the pairs. Each pair will create one reduced workspace.

There will be documentation here This will be all documented and work as explained in documents linked from here http://www.mantidproject.org/Using_the_SANS_GUI_Analysis_Details

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:2 Changed 9 years ago by Steve Williams

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Steve Williams

Personally, I really don’t like the idea of ‘to’.

If not brackets, is there anything else that can be used to separate pairs? a,b ; c,d ; e,f ?

Steve

comment:4 Changed 9 years ago by Steve Williams

In [13542]:

First draft of the user command function re #3015

comment:5 Changed 9 years ago by Anders Markvardsen

  • Status changed from accepted to assigned
  • Owner changed from Steve Williams to Anders Markvardsen

comment:6 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:7 Changed 9 years ago by Anders Markvardsen

  • Status changed from assigned to accepted

An python ISIS SANS command 'PhiRanges' was added with the description:

def PhiRanges(phis, plot=True):

"""

Given a list of phi ranges [a, b, c, d] it reduces in the phi ranges a-b and c-d

Currently PhiRanges is not used anywhere in Mantid.

I have tested this command with:

from ISISCommandInterface import *

SANS2D() MaskFile('MASKSANS2D_094i_RKH.txt') Gravity(False) Set1D() AssignSample('2500.nxs') out = PhiRanges([1, 10, 20, 30]) print help(out) print len(out)

and I am concerned it is not yet coded to do what requested

comment:8 Changed 9 years ago by Anders Markvardsen

Agreed in meeting yesterday that notation "a, b, c, d" meaning do independent reductions a-b and c-d is OK.

Also the output workspaces names must reflect what phi range used. Suggested to append phiNUMBER_NUMBER

comment:9 Changed 9 years ago by Anders Markvardsen

The output of this ticket is the command PhiRanges. Separate ticket for executing this from GUI is #4102.

Remember to display warning if odd number of phi input numbers are provided by user

comment:10 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:11 Changed 9 years ago by Anders Markvardsen

Sans add file extension when phi range. Re #3015

Changeset: edea36dc5a6c55c6464cf8a5952cb6a543fa73d1

comment:12 Changed 9 years ago by Anders Markvardsen

In connection with change to re #3015

Changeset: 6277aac67a17269e5c06d7d1f6d49421b3387b15

comment:13 Changed 9 years ago by Anders Markvardsen

Don't add phi file extension when 2D reduction. Re #3015

Changeset: d68a8e022409fd3c918eddd111523c1f6c4b6f7c

comment:14 Changed 9 years ago by Anders Markvardsen

  • Milestone changed from Iteration 33 to Iteration 32

comment:15 Changed 9 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

This one has been fixed and it has been verified by Richard Heenan during last weeks scientist testing period that it works. Apologizes for forgetting to close this ticket earlier. If someone insist on testing this, in addition to Richard, then load data into ISIS SANS GUI, e.g. use the test data in systemtest SANS2DMultiPeriodAddFiles and also the mask file this systemtest is using

comment:16 Changed 9 years ago by Nick Draper

  • Status changed from verify to closed

Closed at iteration end

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3862

Note: See TracTickets for help on using tickets.