Ticket #3025 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Use a typedef for signal and for coordinates (in MDEvents)

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Rename CoordType to coord_t to match other typedef's like size_t, detid_t, etc.

Make a typedef for the signal type, signal_t, that will likely be a double.

That way, if we need to change the data size for these types of data (float for coordinates, double for signal, vice-versa?) it will be ~trivial. Especially useful if data sizes change in future and we want to fix it on all platforms.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

(In [11533]) Refs #3025: Typedef for signal

comment:3 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:5 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

Sensible change. I Should consider applying the same sort of changes to similar code in VatesAPI.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3872

Note: See TracTickets for help on using tickets.