Ticket #3112 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

SpatialGrouping: algorithm crashes

Reported by: Michael Whitty Owned by: Nick Draper
Priority: minor Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Since Martyn's update to the NearestNeighbours feature:

When spectra:detector map not 1:1 (ie, as it is in most ISIS instruments where it's 1:0) or when presented with grouped workspace. unit test did not replicate this situation. Causes a crash of Mantid.

There are now major performance issues with this algorithm that I am not going to have time to solve. Suggest someone looks into it if anyone actually cares about the algorithm.

Change History

comment:1 Changed 9 years ago by Michael Whitty

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Michael Whitty

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [12160]) fixes #3112

comment:3 Changed 9 years ago by Nick Draper

  • Owner changed from Michael Whitty to Martyn Gigg

Moved from Michael Whitty, ask Martyn if you have any questions during testing

comment:4 Changed 9 years ago by Nick Draper

  • Owner changed from Martyn Gigg to Nick Draper

Moved so they can be tested

comment:5 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:6 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to closed

Algorithm no longer crashes but as the ticket suggests the performance could be improved. New ticket #3261

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3959

Note: See TracTickets for help on using tickets.