Ticket #3131 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Plus has stopped being commutative

Reported by: Russell Taylor Owned by: Janik Zikovsky
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description (last modified by Russell Taylor) (diff)

Add two (histogram) workspaces together and the output always has the size of the first/lhs input workspace - e.g. WorkspaceSingleValue + Workspace2D results in a WorkspaceSingleValue.

Previously, this operation would give a Workspace2D with the single value added to every cell of the input Workspace2D (i.e. we swapped the binary operands over underneath).

At some point - I don't know when - the behaviour changed. We should restore the previous behaviour.

N.B. Multiply still does swap things around.

Change History

comment:1 Changed 9 years ago by Russell Taylor

  • Description modified (diff)

comment:2 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:3 Changed 9 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Anyone

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:5 Changed 9 years ago by Janik Zikovsky

  • Status changed from assigned to accepted
  • Owner changed from Anyone to Janik Zikovsky

comment:6 Changed 9 years ago by Janik Zikovsky

Refs #3131: 1.0 + WS is again commutative

Changeset: 63a568634b82d87cb0574fc6a73b07bcd899b9fd

comment:7 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Note to testers: this should work from MantidPlot and Python

comment:8 Changed 9 years ago by Janik Zikovsky

Refs #3131 fixed return type of binary ops in python

(at least in system tests, where it came back as IMDWorkspace not MatrixWorkspace)

Changeset: cef9db2d291121b6ebe5b18eb1734315bbcafbf2

comment:9 Changed 9 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:10 Changed 9 years ago by Wenduo Zhou

  • Status changed from verifying to closed

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3978

Note: See TracTickets for help on using tickets.