Ticket #3135 (closed: fixed)
Implement IMDBox as a subclass of SignalAggregate
Reported by: | Janik Zikovsky | Owned by: | Janik Zikovsky |
---|---|---|---|
Priority: | critical | Milestone: | Iteration 29 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Owen Arnold |
Description
Change History
comment:3 Changed 9 years ago by Janik Zikovsky
- Status changed from accepted to verify
- Resolution set to fixed
comment:4 Changed 9 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:5 Changed 9 years ago by Owen Arnold
- Status changed from verifying to reopened
- Resolution fixed deleted
getVertexes() is implemented to throw. I think this is important because if this were implemented fully it should be possible to define an IMDIterator (perhaps as a separate ticket) and then iterate through all IMDBoxes in the workspace, extracting geometric information on the fly.
Open to discussion here.
comment:6 Changed 9 years ago by Janik Zikovsky
But getVertexes() is implemented as of rev 12324:
http://trac.mantidproject.org/mantid/changeset/12324
Did I miss a throw call somewhere else?
comment:8 Changed 9 years ago by Janik Zikovsky
- Status changed from accepted to verify
- Resolution set to fixed
comment:10 Changed 9 years ago by Owen Arnold
- Status changed from verifying to closed
Sorry, this was actually always doing the right thing. Should not have been reopened. getVertex is not throwing and has working + passing unit tests.
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 3982