Ticket #3151 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

UpdateInstrumentFromFile should ignore monitors

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: alex.buts@… Blocked By:
Blocking: Tester: Anders Markvardsen

Description

Given that UpdateInstrumentFromFile assumes minor position changes and the monitors are fixed, ignore them in this algorithm.

This also solves a problem with some raw files having bad monitor positions.

Change History

comment:1 Changed 9 years ago by Alex Buts

  • type changed from enhancement to defect

MAP still load incorrect monitor position (wrong sign) if "datafile" is selected as source of data for Homering in Maps_Parameters.xml

comment:2 Changed 9 years ago by Martyn Gigg

(In [12458]) Add an option to the UpdateInstrumentFromFile algorithm to MoveMonitors if requested. This allows more flexibility with some files that are known to have incorrect monitors positions. Re #3151. A minor update to a system test result is required. Also fixed a filename case issue for running system tests on Linux.

comment:3 Changed 9 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:4 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:6 Changed 9 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Looks good included the additional UpdateInstrumentFromFile option

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3998

Note: See TracTickets for help on using tickets.