Ticket #3175 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

UB matrices to be accepted as algorithms parameters

Reported by: Nick Draper Owned by: Martyn Gigg
Priority: critical Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

As this is only a few numbers for now I suggest we use formatted text as a middle man.

Change History

comment:1 Changed 9 years ago by Martyn Gigg

(In [12528]) Refs #3175. Add a MatrixProperty that will allow Geometry::Matrix objects to be passed into algorithms. Also renamed the MantidMat typedef to DblMatrix so that it's clearer what the thing actually is.

comment:2 Changed 9 years ago by Martyn Gigg

(In [12529]) Refs #3175 Avoid template variable class.

comment:3 Changed 9 years ago by Martyn Gigg

(In [12530]) Correction for file path. Re #3175

comment:4 Changed 9 years ago by Martyn Gigg

(In [12570]) Refs #3175. Move the macro for defining IPropertyManager::getValue functions to the header so that all user-defined types can access it. Also implement a test for MatrixProperties being passed to algorithms. We have one problem now with this kind of code: DblMatrix R = getProperty("R"). IPropertyManager can't define a template conversion operator because Visual Studio has a problem with the std::string version that even a specialization doesn't cure.

comment:5 Changed 9 years ago by Martyn Gigg

(In [12571]) Fix for the intel compiler. Refs #3175

comment:6 Changed 9 years ago by Martyn Gigg

(In [12605]) Refs #3175. Sorry for the huge commit but certain things require Matrix to be in Kernel. Given how Quat, V3D and Matrix inter cooperate it seemed sensible for them to be in the same place and arguably this is where they belong anyway.

comment:7 Changed 9 years ago by Martyn Gigg

(In [12606]) Fix Linux build and remove a warning. Refs #3175

comment:8 Changed 9 years ago by Martyn Gigg

(In [12607]) Kill a warning. Refs #3175

comment:9 Changed 9 years ago by Martyn Gigg

(In [12609]) Move MatrixProperty to Kernel, there's no sense it being in API now. Also expose Matrix types to IPropertyManager. We may have to figure out a better design for the TypedValue situation but for now we're good. Refs #3175

comment:10 Changed 9 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:11 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:12 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:13 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4022

Note: See TracTickets for help on using tickets.