Ticket #3188 (closed: wontfix)

Opened 9 years ago

Last modified 5 years ago

Consider removing AlignDetectors

Reported by: Nick Draper Owned by: Nick Draper
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

By allowing Convert Units to take an offsets workspace.

Workspace with a bin containing the offset.

Change History

comment:1 Changed 9 years ago by Russell Taylor

My two cents: The primary purpose of this algorithm is to correct the positions of detectors. It's a side effect of how they measure the correction that means it also changes the units. I think it's dubious to add an option that (relatively) few will use to an algorithm that absolutely everyone uses. BTW, the current AlignDetectors doesn't use code from ConvertUnits. Actually lots of it has ended up on Instrument, which I hadn't noticed before and I'm not too sure about.

comment:2 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:3 Changed 9 years ago by Nick Draper

  • Status changed from new to verify
  • Owner set to Nick Draper
  • Resolution set to wontfix

I agree with Russell

comment:4 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:5 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

OK, nothing to see here.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4035

Note: See TracTickets for help on using tickets.