Ticket #3197 (closed: fixed)
Create a 2D rebinning algorithm
Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
---|---|---|---|
Priority: | major | Milestone: | Iteration 30 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Stuart Campbell |
Description
Change History
comment:10 Changed 9 years ago by Martyn Gigg
comment:11 Changed 9 years ago by Martyn Gigg
comment:12 Changed 9 years ago by Martyn Gigg
comment:13 Changed 9 years ago by Martyn Gigg
comment:14 Changed 9 years ago by Martyn Gigg
comment:15 Changed 9 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
It's ready to test. A workspace with a spectra axis will need ConvertSpectrumAxis running first. It should probably be done as part of the algorithm but it is horrendously slow at the moment so I chose not to for the time being.
comment:16 Changed 9 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester set to Wenduo Zhou
comment:17 Changed 9 years ago by Wenduo Zhou
- Status changed from verifying to verify
- Tester Wenduo Zhou deleted
comment:18 Changed 9 years ago by Stuart Campbell
- Status changed from verify to verifying
- Tester set to Stuart Campbell
comment:19 Changed 9 years ago by Stuart Campbell
There is no wiki page - created ticket #3268
comment:20 Changed 9 years ago by Stuart Campbell
- Status changed from verifying to closed
It seems to work, but it is not the most intuitive algorithm at the moment! :-)
comment:21 Changed 9 years ago by Martyn Gigg
- Status changed from closed to reopened
- Resolution fixed deleted
- Milestone changed from Iteration 29 to Iteration 30
Jon Taylor has demonstrated some oddities to me that mean that this isn't quite right yet so lets not broadcast it for the release.
comment:22 Changed 9 years ago by Stuart Campbell
Just a suggestion; but should we close this one under iteration 29 (as this was where the work has been done) and create new tickets for the problems Jon has seen under the next iteration?
comment:24 Changed 9 years ago by Martyn Gigg
comment:25 Changed 9 years ago by Martyn Gigg
comment:26 Changed 9 years ago by Martyn Gigg
Following advice from Michael Reuter I'm going to implement the implementation of polygon intersection by M. Laszlo to avoid the precisison problems with the implementation by O Rourke.
I'll close this one and I have created a new ticket, #3341, for this.
comment:27 Changed 9 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:28 Changed 9 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester changed from Stuart Campbell to Owen Arnold
comment:29 Changed 9 years ago by Owen Arnold
- Status changed from verifying to verify
- Tester Owen Arnold deleted
Tested using combintation of CreateWorkspace and Rebin2D. No issues. Worth going back to original tester before signing-off.
comment:30 Changed 9 years ago by Stuart Campbell
- Status changed from verify to verifying
- Tester set to Stuart Campbell
comment:31 Changed 9 years ago by Stuart Campbell
- Status changed from verifying to closed
Looks good to me. I basically read in some (BASIS) data, converted to EnergyTransfer, Rebinned, ConvertedSpectrum Axis to Q, then ran Rebin2D...
comment:32 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 4044
(In [12639]) Add a Vertex and ConvexPolygon class to aid in 2D rebinning. Re #3197