Ticket #3239 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Fix broken tests

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: blocker Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description


Change History

comment:1 Changed 9 years ago by Martyn Gigg

Start of testing week has these tests failing on Windows 7:

TEST-DataObjectsTest.EventWorkspaceTest.xml.<init> TEST-AlgorithmsTest.AlignDetectorsTest.xml.<init> TEST-AlgorithmsTest.ChangeBinOffsetTest.xml.<init> TEST-DataHandlingTest.LoadEventPreNeXusTest.xml.<init> TEST-AlgorithmsTest.ConjoinWorkspacesTest.xml.<init> TEST-AlgorithmsTest.ConvertUnitsTest.xml.<init> TEST-AlgorithmsTest.FilterByTimeTest.xml.<init>

comment:2 Changed 9 years ago by Martyn Gigg

(In [12844]) Fix an off-by-one error picked up why MSVC. Refs #3239

comment:3 Changed 9 years ago by Martyn Gigg

And the Windows 32-bit build has this failure:

  • GeometryTest.IndexingUtilsTest.test_BestFit_UB_given_lattice_parameters

comment:4 Changed 9 years ago by Martyn Gigg

(In [12845]) Add in machine's double precision to account for possible less-than within precision. Refs #3239

comment:5 Changed 9 years ago by Martyn Gigg

  • Status changed from new to accepted
  • Owner set to Martyn Gigg

comment:6 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:8 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

This has fixed All 32bit and 64bit Windows builds.

comment:9 Changed 9 years ago by Martyn Gigg

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:10 Changed 9 years ago by Martyn Gigg

We still have a failing system test, HFIRReduction, so I'm going to leave this open for that.

comment:11 Changed 9 years ago by Martyn Gigg

(In [12858]) Update the stresstesting framework to be able to validate between to loaded workspaces again. Refs #3239

comment:12 Changed 9 years ago by Martyn Gigg

  • Status changed from reopened to accepted

comment:13 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

Everything looks good now.

comment:14 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying

comment:15 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

All system tests passed for nightly build to complete. Unit tests fixed yesterday.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4086

Note: See TracTickets for help on using tickets.