Ticket #3257 (closed: invalid)

Opened 9 years ago

Last modified 5 years ago

DiffractionFocussing2: Possible difference in Q 2D vs Event?

Reported by: Janik Zikovsky Owned by: Anders Markvardsen
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description (last modified by Anders Markvardsen) (diff)

The following scripts shows a fairly significant difference between the Workspace2D and event versions of the algorithm: 

# 2D version
LoadEventNexus(Filename="/home/8oz/data/PG3_1370_event.nxs",OutputWorkspace="pg3",CompressTolerance="0.050000000000000003")
ConvertUnits(InputWorkspace="pg3",OutputWorkspace="pg3",Target="MomentumTransfer")
Rebin(InputWorkspace="pg3",OutputWorkspace="pg3",Params="0,1,40")
CreateGroupingWorkspace(InstrumentName="PG3",GroupNames="bank124,bank144,bank164,bank184",OutputWorkspace="pg3_group")
ConvertToMatrixWorkspace(InputWorkspace="pg3",OutputWorkspace="pg32d")
DiffractionFocussing(InputWorkspace="pg32d",OutputWorkspace="pg3_foc_2d",GroupingWorkspace="pg3_group")

# Event version
CreateGroupingWorkspace(InstrumentName="PG3",GroupNames="bank124,bank144,bank164,bank184",OutputWorkspace="pg3_group")
DiffractionFocussing(InputWorkspace="pg3",OutputWorkspace="pg3_foc",GroupingWorkspace="pg3_group")

Minus("pg3_foc", "pg3_foc_2d", "pg3_diff")

If you compare pg3_foc and pg3_foc_2d on a plot, they look pretty different. I'm not sure if this is specific to Q; or if it has something to do with Martyn's "fixes" to spectrum numbers.

Refs #3065

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Anyone

comment:2 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:7 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:8 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:9 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:10 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:11 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:12 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:13 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Anyone to Anders Markvardsen
  • Status changed from assigned to verify
  • Resolution set to invalid
  • Description modified (diff)

When I try to run it with systemtest/data/PG3_2538_event.nxs the script above returns: 

DiffractionFocussing started
Error in execution of algorithm DiffractionFocussing:
All arguments to init must be positive and non-zero

comment:14 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery
  • Milestone changed from Backlog to Release 3.3

comment:15 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Same error here

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4104

Note: See TracTickets for help on using tickets.