Ticket #3286 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

PDFFourierTransform improvements

Reported by: Nick Draper Owned by: Wenduo Zhou
Priority: critical Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

  • The properties RMax, DeltaR, Qmin, Qmax, and DebugMode need to be documented (in the property declarations) including the fact that Qmin and Qmax default to the data range.
  • The documentation for the InputWorkspace does not state that it can be in Q or d.
  • The printing that is hiding in #if 0 should be converted to logging at debug level.
  • Remove the DebugMode property.
  • Rename OutputWorkspace0 and OutputWorkspace1 to be something meaningful. In other algorithms you will see one output workspace property and the algorithm generates two names.
  • Trim the Q(S(Q)-1) Q range to be that selected to be Fourier transformed.

Change History

comment:1 Changed 9 years ago by Wenduo Zhou

In [13327]:

Modify to fix a bug. Refs #3286

comment:2 Changed 9 years ago by Wenduo Zhou

In [13381]:

Updated codes of BlendSq (blending S(q)). Refs #3286.

comment:3 Changed 9 years ago by Wenduo Zhou

In [14108]:

Some minor changes including more detailed documentation and output workspace name. Refs #3286.

comment:4 Changed 9 years ago by Wenduo Zhou

In [14454]:

PDF Fourier Transform can take S(Q)-1 as another option to input. Refs #3286.

comment:5 Changed 9 years ago by Wenduo Zhou

PDFFourierTransform's wiki page (http://www.mantidproject.org/PDFFourierTransform) is improved for more detailed and accurate information.

comment:6 Changed 9 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:7 Changed 9 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 9 years ago by Wenduo Zhou

In [14563]:

Applied some minor change for better user interface. Refs #3286.

comment:9 Changed 9 years ago by Wenduo Zhou

In [14564]:

Check in the header with some modification. Refs #3286.

comment:10 Changed 9 years ago by Wenduo Zhou

In [14565]:

Removed some unnecessary codes. Refs #3286.

comment:11 Changed 9 years ago by Russell Taylor

In [14721]:

Tidy up. Re #3286.

comment:12 Changed 9 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:13 Changed 9 years ago by Vickie Lynch

  • Status changed from verifying to closed

Seems to work correctly.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4133

Note: See TracTickets for help on using tickets.