Iteration 30 Warning Fixes.

[Janik Zikovsky]

General ticket for compiler warning fixes

[Martyn Gigg]

(In [12992]) Minor tweak to CMAKE_BUILD_TYPE so that the options in the GUI are listed rather than requiring a string. Re #3302

[Janik Zikovsky]

(In [13051]) Fixes #3321: deprecated DiffractionFocussing1. Fix tests in release version (refs #3203). Fix a few warnings Refs #3302.

[Janik Zikovsky]

(In [13055]) Refs #3302: Fix several warnings.

[Russell Taylor]

In [13131]:

Eliminate a ubiquitous Intel compiler warning. Re #3302.

[Russell Taylor]

In [13139]:

Fix Intel compiler warnings. Re #3302.

[Janik Zikovsky]

In [13152]:

Refs #3302: Fix warning.

[Janik Zikovsky]

In [13153]:

Refs #3302: Fix last 2 warnings.

[Janik Zikovsky]

In [13154]:

Refs #3302: Fix warning without breaking test.

[Russell Taylor]

In [13159]:

Clear Intel warnings. Re #3302.

[Janik Zikovsky]

In [13192]:

Refs #3302: Warning fix.

[Russell Taylor]

In [13202]:

Kill off more Intel compiler warnings. Re #3302.

[Russell Taylor]

In [13232]:

Remove Intel compiler warnings coming out of Boost by using the -isystem flag when including the headers. Have to enable this possibility in CMake as by default it doesn't use it on the Mac. Re #3302.

[Janik Zikovsky]

In [13244]:

Refs #3302: Warnings

[Russell Taylor]

In [13277]:

Clear last remaining Intel warnings related to CurveFitting. Fixes #3352. Clear some other Intel warnings as well. Re #3302.

[Roman Tolchenov]

In [13406]:

Clearing some warnings. re #3302

[Nick Draper]

In [13525]:

re #3302
Version number change

[Russell Taylor]

In [13532]:

Clean namespace pollution. Re #3302.

[Michael Reuter]

In [13641]:

Subduing weird compiler warning. This refs #3302.

[Martyn Gigg]

In [13675]:

Refs #3302. Avoid a warning with CMake on the Mac.

[Andrei Savici]

In [13683]:

Fixes some warnings. Refs #3302

[Russell Taylor]

In [13772]:

Clear a few Intel compiler warnings. Re #3302.

[Janik Zikovsky]

In [13787]:

Refs #3302: Fix some compiler warnings on the Mac build.

[Russell Taylor]

In [13794]:

Chipping away at intel compiler warnings. Re #3302.

[Russell Taylor]

In [13822]:

Chipping away at intel compiler warnings. Re #3302.

[Russell Taylor]

In [13843]:

More Intel compiler warnings gone. Should only be 1 left now (excluding tests). Re #3302.

[Russell Taylor]

In [13844]:

Fix typo to squash last Intel compiler warning. Re #3302.

[Russell Taylor]

In [13859]:

Remove an ld warning on the Mac & also downgrade a LoadInstrument logging message that was too prominent. Re #3302.

[Martyn Gigg]

In [13885]:

Refs #3302. Trying to generate Python tests again that don't seem to update

[Martyn Gigg]

In [13887]:

Refs #3302. Fix a dependency issue when building the python unit tests.

[Martyn Gigg]

In [13889]:

Refs #3302. Will this do it?

[Russell Taylor]

In [13895]:

Starting on Intel warnings in the tests. This should immediately get rid of most of them. Re #3302.

[Russell Taylor]

In [13896]:

This should be most of the other Intel warnings in the tests. Re #3302.

[Janik Zikovsky]

In [13901]:

Refs #3302: Fix warnings

[Janik Zikovsky]

In [13902]:

Refs #3532: Track box total signal whenever you save it to disk. Refs #3302: Hope to really fix warnings now.

[Russell Taylor]

In [13903]:

Re #3302.

[Russell Taylor]

In [13909]:

Should only be 1 Intel warning left now. Re #3302.

[Roman Tolchenov]

In [13917]:

Removing a warning. re #3302

[Martyn Gigg]

In [13955]:

Refs #3302. Clear MSVC compiler warnings regarding bit-shift operators.

[Martyn Gigg]

In [13956]:

Refs #3302. Fix tests

[Martyn Gigg]

In [13957]:

Refs #3302. Okay, leave that warning for now.

[Martyn Gigg]

In [13958]:

Refs #3302. Fix warning properly.

[Russell Taylor]

In [13998]:

Try to fix Mac test failures. Looks to be code in the destructor of another test causing the problem. Re #3302.

[Michael Reuter]

In [14154]:

Taking care of some VATES warnings. This refs #3302.

[Russell Taylor]

In [14216]:

Clear new Intel compiler warnings. Re #3302.

[Nick Draper]

In [14299]:

re #3302
dropping a const to remove warnings

[Nick Draper]

In [14301]:

re #3302
quashing some unused variable warnings from the tests

[Peter Peterson]

In [14304]:

Quieting implicit cast warning. Refs #3302.

[Michael Reuter]

In [14311]:

Windows warning fixes. This refs #3302.

[Michael Reuter]

In [14349]:

Using MS suggestion to fix warnings. This refs #3302.

[Michael Reuter]

In [14360]:

More Windows warnings. This refs #3302.

[Janik Zikovsky]

In [14363]:

Refs #3302: class_maker test improvement

[Russell Taylor]

In [14364]:

eol. Re #3302.

[Martyn Gigg]

In [14417]:

Refs #3302. Activate windows compiler warning that should make MSVC treat signed/unsigned comparisons in the same manner as gcc.

[Roman Tolchenov]

In [14455]:

A file counter hit a limit. A quick fix to extend the limit. re #3302

[Stuart Campbell]

In [14472]:

cppcheck fixes. refs #3302

[Stuart Campbell]

In [14473]:

Change to catch by reference. refs #3302

[Stuart Campbell]

In [14474]:

Change to catch by reference. refs #3302

[Stuart Campbell]

In [14475]:

Change to catch by reference. refs #3302

[Peter Peterson]

In [14476]:

Fixing postfixOperator warnings. Refs #3302.

[Stuart Campbell]

In [14477]:

Change to catch by reference. refs #3302

[Peter Peterson]

In [14479]:

Fixing postfixOperator warnings. Refs #3302.

[Martyn Gigg]

In [14485]:

Export the access functions for the oriented lattice from the sample class. Fixes #3680. Also cleared some warnings on windows. Refs #3302

[Martyn Gigg]

In [14488]:

Kill some prevalent warnings on Windows. Refs #3302.

[Peter Peterson]

In [14495]:

Fixing cppcheck postfix warnings. Refs #3302.

[Peter Peterson]

In [14497]:

Refs #3302

[Peter Peterson]

In [14498]:

Postfix operator again. Refs #3302.

[Martyn Gigg]

In [14523]:

Kill remaining gcc compiler warnings. Refs #3302

[Martyn Gigg]

In [14526]:

Further windows warnings cull Refs #3302

[Martyn Gigg]

In [14527]:

Fix the win32 build problem. Refs #3302

[Martyn Gigg]

In [14590]:

Refs #3302. Fix build.

[Martyn Gigg]

In [14591]:

Refs #3302. Fix build.

[Martyn Gigg]

In [14607]:

Fix for PYTHON_EXECUTABLE variable on Windows that seems to disappear sometimes. Most notably on the clean windows 7 builds. Refs #3302

[Michael Reuter]

In [14650]:

Removing file from MOC list to fix natty warning. This refs #3302.

[Martyn Gigg]

In [14691]:

Fix a couple of warnings Refs #3302

[Nick Draper]

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

[Martyn Gigg]

In [14756]:

Add a couple of Qt Dlls to the windows installer that are required. Refs #3302.

[Russell Taylor]

In [14766]:

Remove debug cout output. Re #3302.

[Russell Taylor]

In [14792]:

Update category to be consistent, if equally meaningless. Re #3302.

[Russell Taylor]

In [14793]:

Update algorithm categories for consistency. Re #3302.

[Janik Zikovsky]

In [14800]:

Refs #3302: Minor script tweaks

[Russell Taylor]

In [14805]:

Fix spelling error. Re #3302.

[Russell Taylor]

Pinching an easy one!

[Russell Taylor]

The current state of play on the ORNL clean builds (which include the tests):

• ornl_clean_rhel6_vates - 0 warnings
• ornl_clean_lucid - 0 warnings
• ornl_clean_snowleopard - 11 warnings - but these are all 'known' and will be addressed after the release
• ornl_clean_windows7 - oddly, sometimes says 53 warnings, sometimes 0

[Stuart Campbell]

This ticket has been transferred to github issue ​4149