improve workspace's getDetector method

[Anders Markvardsen]

While helping Matt it was found that running the following script

ws = mtdPEARL00071180? inst = ws.getInstrument()

origin = ws.getInstrument().getSample().getPos()

for i in range(0, ws.getNumberHistograms()):

print i, " ", ws.getDetector(i).getTwoTheta(origin, V3D(0,0,1))*180/math.pi, " ", ws.getDetector(i).isMasked()

mask = [] for i in range(0, ws.getNumberHistograms()):

angle = ws.getDetector(i).getTwoTheta(origin, V3D(0,0,1))*180/math.pi if angle > 97 or angle < 83:

mask.append(i)

MaskDetectors("PEARL00071180",WorkspaceIndexList=mask)

print "after masking" for i in range(0, ws.getNumberHistograms()):

print ws.getDetector(i).getTwoTheta(origin, V3D(0,0,1))*180/math.pi, " ", ws.getDetector(i).isMasked()

generated the following error:

RuntimeError on line 7: "Instrument: Detector with ID 6 not found. search object" in file 'mask_detectors.py' at line 7

The problem is something along the lines of histograms in the workspace exists for which no detector exists

[Nick Draper]

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

[Anders Markvardsen]

Just discussed this ticket with Martyn and yes, when user see this error they have to use try catch blocks

[Nick Draper]

try catch blocks are most helpful, especially in situations like this.

[Stuart Campbell]

This ticket has been transferred to github issue ​4174