Ticket #3353 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

MDHistoDimension: XML does not preserve units string

Reported by: Janik Zikovsky Owned by: Owen Arnold
Priority: minor Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

If you create a MDHistoDimension object with the units specified and then serialize them to XML, and read them back using the IMDDimensionFactory, the units are not being read back.

Change History

comment:1 Changed 9 years ago by Owen Arnold

Agree. This is an issue. As a description of units can actually be quite complicated (many fields) they were originally left out of the xml schema. If a simple string field will suffice, this can easily be fixed.

comment:2 Changed 9 years ago by Janik Zikovsky

Right now the MDHistoDimension object only has units as a simple string, so serializing it as a string would be totally fine.

comment:3 Changed 9 years ago by Owen Arnold

In [13272]:

Refs #3353. Should now preserve units.

comment:4 Changed 9 years ago by Owen Arnold

In [13273]:

Refs #3353. Fix test.

comment:5 Changed 9 years ago by Owen Arnold

  • Status changed from new to accepted

comment:6 Changed 9 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:8 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

Works in e.g. SaveMD/LoadMD cycle.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4200

Note: See TracTickets for help on using tickets.