Ticket #3374 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

DiffractionEventCalibrateDetectors improvements

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: minor Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description

DiffractionEventCalibrateDetectors uses deprecated Sort, has incorrect progress bar, and does not delete temporary grouping workspaces.

Attachments

SNAP_4307_DetCal.png​ (439.3 KB) - added by Vickie Lynch 9 years ago.

Change History

comment:1 Changed 9 years ago by Vickie Lynch

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Vickie Lynch

In [13224]:

Refs #3374 Fixed Progress bar, SortEvents now, deleted temporary grouping workspaces

comment:3 Changed 9 years ago by Vickie Lynch

In [13227]:

Refs #3374 Correct extension for DetCal file; check numbers in DetCal file in test

comment:4 Changed 9 years ago by Vickie Lynch

Tried making detector loop parallel, but child routines are already parallel so nested OpenMP parallelism increased the memory and did not reduce the wall clock time.

Changed 9 years ago by Vickie Lynch

comment:5 Changed 9 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

Results for calibration of SNAP_4307 after changes in algorithm attached

comment:6 Changed 9 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:7 Changed 9 years ago by Wenduo Zhou

  • Status changed from verifying to closed

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4221

Note: See TracTickets for help on using tickets.