Ticket #3378 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Make behaviour of ISpectrum::maskSpectrum consistent

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

At the moment, EventList wipes out all the events - so effectively zeroes the data - whereas Histogram1D allows the option of setting all the data points to some value other than zero that's passed in (this parameter is ignored in EventList). This is a potential inconsistency. The option is never used anyway outside of tests, so just remove it.

Also, rename the method to avoid the impression that some masking flag is set - it simply clears off the data.

Change History

comment:1 Changed 9 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Russell Taylor

In [13239]:

Rename ISpectrum::maskSpectrum() to clearData() and remove option to set histogram data to a value other than zero as it was an inconsistency. Re #3378.

comment:3 Changed 9 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:5 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

Verified by code inspection.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4225

Note: See TracTickets for help on using tickets.