Ticket #3396 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

SANS: turn SANSSolidAngleCorrection into a workflow algorithm

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

SANSSolidAngleCorrection can be re-written to use SolidAngle. All that is needed is to determine the solid angle of the pixel nearest to (0,0) and compute the ratio.

We need to be backward compatible with HFIR calculations, so we may need to leave the original calculation as an option.

Change History

comment:1 Changed 9 years ago by Mathieu Doucet

In [13314]:

Remove dependence on SANSSolidAngleCorrection in the algorithms unit tests. Re #3396

comment:2 Changed 9 years ago by Mathieu Doucet

In [13316]:

Moved SANSSolidAngleCorrection to WorkflowAlgorithms, and cleaned those up a little. Re #3396

comment:3 Changed 9 years ago by Mathieu Doucet

In [13318]:

Should fix CalculateEfficiencyTest Re #3396

comment:4 Changed 9 years ago by Mathieu Doucet

In [13319]:

Move test IDF to its proper place. Re #3396

comment:5 Changed 9 years ago by Mathieu Doucet

In [13324]:

hook up SANSSolidAngleCorrection directly into SansReducer as a workflow algorithm. Some cleanup as well. Re #3396

comment:6 Changed 9 years ago by Mathieu Doucet

  • Status changed from new to accepted

comment:7 Changed 9 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 9 years ago by Martyn Gigg

In [13674]:

Fix for the Intel compiler on the mac which freezes if it encounters a continue statement inside a catch block that is in an OpenMP for loop. Refs #3396

comment:9 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:10 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to closed

Confirmed that HFIRReduction uses SANSSolidAngleCorrection as a workflow algorithm. The reduction completes successfully and the system tests pass.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4243

Note: See TracTickets for help on using tickets.