Ticket #3397 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Consider how AnvredCorrection can be integrated with our existing absorption correction algorithms

Reported by: Russell Taylor Owned by: Vickie Lynch
Priority: minor Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

This algorithm is for absorption corrections in a spherical sample. It's been imported from another software package and keeps the interface (and name) that users of that package are used to.

It would be good to look at how this algorithm (or at least its interface) can be brought into the fold of our other absorption correction algorithms. One option would be to keep AnvredCorrection as it is - off to the side in Crystal and with the name and parameters that some people are used to - and to wrap it with a pass-through algorithm that has the parameters in a form analogous to our other absorption correction algorithms and with a meaningful name such that someone looking to correct absorption in a spherical sample would actually find it!

There are certainly other, probably better, options that may be uncovered by a discussion involving the interested parties.

Change History

comment:1 Changed 9 years ago by Vickie Lynch

In [13315]:

Refs #3397 Corrected header information in AnvredCorrection.h

comment:2 Changed 9 years ago by Vickie Lynch

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Vickie Lynch

In [14031]:

Refs #3397 SphericalAbsorption Correction algorithm to wrap AnvredCorrection

comment:4 Changed 9 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

Color fill plot of corrections looks very similar to corrections from CylindricalCorrection with similar size sample. Will add wiki page.

comment:5 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:6 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

When run with the correctly mapped setting, both algorithms give the same answer.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4244

Note: See TracTickets for help on using tickets.