Ticket #3408 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

MDBoxIterator limited by a MDImplicitFunction

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: critical Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By: #3376
Blocking: #3369 Tester: Owen Arnold

Description

That is, iterate through all the MDBoxes in a MDEventWorkspace, but skip any boxes that are outside of the range of interest.

This should make algorithms that iterate through all events much more efficient (especially Re: file-back-end).

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

  • Priority changed from major to critical
  • Blocking 3369 added
  • Blocked By 3376 added

comment:3 Changed 9 years ago by Janik Zikovsky

In [13390]:

Refs #3408: Moved MDImplicitFunction to the Geometry project so I could use it in iterator.

comment:4 Changed 9 years ago by Janik Zikovsky

In [13391]:

Refs #3408: Missing files

comment:5 Changed 9 years ago by Janik Zikovsky

In [13394]:

Refs #3408: MDBoxIterator with option to limit by an implicit function, lots of tests.

comment:6 Changed 9 years ago by Janik Zikovsky

In [13430]:

Refs #3415: getBoxes() limited by ImplicitFunction. Also refs #3408.

comment:3 Changed 9 years ago by Janik Zikovsky

In [13452]:

Refs #3408: My illiteracy caused the performance test not to be picked up by ctest (typo fix :) )

comment:4 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

It works, but it is a whole lot slower than #3415: getBoxes() limited by ImplicitFunction.

I will leave it in (I don't think it slows anything down to any significant degree if you give a NULL implicit function), but it is probably not as useful.

comment:5 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:6 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

Code is definitely making use of isBoxTouching() method. Excellent Test suite with diagram explaining test set used by test_iterator_withImplicitFunction_.. type methods.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4255

Note: See TracTickets for help on using tickets.