Ticket #3413 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Allow dimensionless units for formula fitting parameters

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

At present a formula fitting parameter has the syntax

<parameter name="IkedaCarpenterPV:Alpha0" type="fitting">

<formula eq="0.734079" unit="TOF" result-unit="TOF"/> <fixed />

</parameter>

where unit and result-unit are not optional. Allow these to be optional and where the default is no unit.

Change History

comment:1 Changed 9 years ago by Anders Markvardsen

  • Status changed from new to accepted
  • Summary changed from Allow dimensional units for formula fitting parameters to Allow dimensionless units for formula fitting parameters

comment:2 Changed 9 years ago by Anders Markvardsen

Also updated the wiki doc for formula fitting parameter on http://www.mantidproject.org/InstrumentDefinitionFile#Using_fitting_.3Cparameter.3E

comment:3 Changed 9 years ago by Anders Markvardsen

In [13471]:

Cosmetic change to GEM_Parameters.xml to check if
this comment gets added to trac page for this ticket.
(previous one to this ticket didn't)

re #3413

comment:4 Changed 9 years ago by Anders Markvardsen

Also committed the following to this ticket which for some reason did not get registered.

Revision 13418 Allow dimensionless units for formula fitting parameters.

Also moved the fitting for GEM_Definition.xml into GEM_Parameters.xml for clarity which now includes an example where Kappa is dimensionless.

re #3413

comment:5 Changed 9 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 9 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:7 Changed 9 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4260

Note: See TracTickets for help on using tickets.