Ticket #3437 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Algorithm to correct for T0 on BASIS

Reported by: Stuart Campbell Owned by: Jose Borreguero
Priority: minor Milestone: Release 2.1
Component: Mantid Keywords:
Cc: reuterma@… Blocked By:
Blocking: Tester: Stuart Campbell

Description

In the future this probably can be done more gracefully somewhere else, but we need to have a routine that corrects for the neutron emission time offset (i.e. T0). As I understand it the correction is:

t0 = offset + slope*primary_wavelength

We also need to check that Mantid calculates the primary wavelength correctly.

Michael: I'm just adding you as a CC on this ticket so you can see if I do something wrong!

Change History

comment:1 Changed 9 years ago by Stuart Campbell

for BASIS:

offset = -5.0
slope = 11.967

comment:2 Changed 9 years ago by Stuart Campbell

  • Priority changed from major to minor

I am making this a lower priority as it might be just as good to calibrate the incident flight path.

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:4 Changed 9 years ago by Stuart Campbell

On second thoughts this is something that we should do and it should probably be done for ISIS as well.

The algorithm should be able to take the slope/intercept either as inputs or read default values from the parameter file.

comment:5 Changed 9 years ago by Stuart Campbell

  • Status changed from new to assigned
  • Owner changed from Stuart Campbell to Jose Borreguero

Jose - I thought that this might be a nice simple algorithm for you to have a go with.

I have put some default parameters in the BASIS_Parameters.xml file. Feel free to alter the names if you wish.

comment:6 Changed 9 years ago by Stuart Campbell

Added default T0 parameters. refs #3437

Changeset: 7c78a4db8abdc6837a73344162c591a04bb191a5

comment:7 Changed 9 years ago by Jose Borreguero

Refs #3437 New files header and sournce ModeratorTzero files

Changeset: fe09a4495bac87a76433e68d280b86d47c9c434f

comment:8 Changed 9 years ago by Jose Borreguero

Refs #3437 Moved ModeratorTzero* files under Framework/UserAlgoritms

Changeset: b5b60d57d8fdd6ead41723724b943b12ad2e10e0

comment:9 Changed 9 years ago by Jose Borreguero

Refs #3437 Changes in loop over detectors

modified: Framework/Algorithms/inc/MantidAlgorithms/ModeratorTzero.h modified: Framework/Algorithms/src/ModeratorTzero.cpp Changeset: 4de79322b54fe88ffd3b3012a341303b4a334284

comment:10 Changed 9 years ago by Jose Borreguero

Refs #3437 Unit test with a small BASIS events Nexus file

modified: ../../Code/Mantid/Framework/Algorithms/inc/MantidAlgorithms/ModeratorTzero.h modified: ../../Code/Mantid/Framework/Algorithms/src/ModeratorTzero.cpp modified: ../../Code/Mantid/Framework/Algorithms/test/ModeratorTzeroTest.h new file: BSS_11841_event.nxs

Changeset: 423aedc75f013f2b99dd0a2f5b43329b42e76b7d

comment:11 Changed 9 years ago by Jose Borreguero

Refs #3437 Unit test ModeratorTzeroTest completes for events files

  • The test unit ignores pixes with no defined geometry, irrespective of whether they contain events. These events may be construed as background

comment:12 Changed 9 years ago by Jose Borreguero

Refs #3437 Started working on testExec2D

comment:13 Changed 9 years ago by Jose Borreguero

Refs #3437 added handling of histogram data

comment:14 Changed 9 years ago by Jose Borreguero

Refs #3437 Added description of properties for the WIKI page

comment:15 Changed 9 years ago by Jose Borreguero

Refs #3437 Fix reference call to eventlist

comment:16 Changed 9 years ago by Jose Borreguero

Refs #3437 modify debug outputs

comment:17 Changed 9 years ago by Stuart Campbell

refs #3868 & #3437. Sone minor code analysis fixes.

Changeset: 00b0d0103a6034a71775ca0397538ae0a918cb4e

comment:18 Changed 9 years ago by Jose Borreguero

Refs #3437 comment out test prior to debuging

Changeset: 6289191cd4aa329fb19ec0abb4e6b99efa0d5ced

comment:19 Changed 9 years ago by Jose Borreguero

Refs #3437 Correction of Algorithm's category for identification

Changeset: 2db0aaf7b0a8089e2b9adeaebe3a500f9ce84d39

comment:20 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:21 Changed 9 years ago by Jose Borreguero

Refs #3437 Re-enabled testExec2D

comment:22 Changed 9 years ago by Jose Borreguero

Refs #3437 Added BSS_11841_event.nxs to AutoTestData

Changeset: 63b067b676e28f80ecd4539db9b0e0b3bf1cdb87

comment:23 Changed 9 years ago by Jose Borreguero

Refs #3437 testExecEvents re-enabled

testExecEvents run on the Mac OS snowleopard and on Ubuntu 11

Changeset: 2c67c33730495972c93cc1ba14ff4c25d212ebab

comment:24 Changed 9 years ago by Michael Reuter

Refs #3437. T_f needs to be in microseconds.

Changeset: 9fad7415faa373a75deb7973ae22620717836605

comment:25 Changed 9 years ago by Michael Reuter

Refs #3437. Touching up code formatting.

Changeset: 18cf3de985fc66995e1831f8a56fdc1c6756bd0c

comment:26 Changed 9 years ago by Jose Borreguero

Refs #3437 Re-enabled testExec2D

comment:27 Changed 9 years ago by Jose Borreguero

Refs #3437 Added BSS_11841_event.nxs to AutoTestData

Changeset: 63b067b676e28f80ecd4539db9b0e0b3bf1cdb87

comment:28 Changed 9 years ago by Jose Borreguero

Refs #3437 testExecEvents re-enabled

testExecEvents run on the Mac OS snowleopard and on Ubuntu 11

Changeset: 2c67c33730495972c93cc1ba14ff4c25d212ebab

comment:29 Changed 9 years ago by Michael Reuter

Refs #3437. T_f needs to be in microseconds.

Changeset: 9fad7415faa373a75deb7973ae22620717836605

comment:30 Changed 9 years ago by Michael Reuter

Refs #3437. Touching up code formatting.

Changeset: 18cf3de985fc66995e1831f8a56fdc1c6756bd0c

comment:31 Changed 8 years ago by Jose Borreguero

  • Status changed from assigned to accepted

comment:32 Changed 8 years ago by Jose Borreguero

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:33 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:34 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

Looks good. It is in production on the beam line, and has also been checked by the instrument scientists.

comment:35 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4284

Note: See TracTickets for help on using tickets.