Ticket #3448 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Add support for precompiled headers into CMake

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

These have been shown to dramtically increase the speed of the builds.

Change History

comment:1 Changed 9 years ago by Martyn Gigg

In [13586]:

Refs #3448. Use precompiled headers (only on MSVC at the moment)

comment:2 Changed 9 years ago by Martyn Gigg

In [13587]:

Refs #3448. Remove references to old stdafx

comment:3 Changed 9 years ago by Martyn Gigg

In [13589]:

Refs #3448 Another stdafx reference

comment:4 Changed 9 years ago by Martyn Gigg

In [13590]:

Refs #3448 Remove un-referenced namespace

comment:5 Changed 9 years ago by Martyn Gigg

In [13593]:

Refs #3448 Fix MDAlgorithms and tests builds. Not quite sure why these worked for me initially.

comment:6 Changed 9 years ago by Martyn Gigg

In [13594]:

Refs #3448 Fix MDEvents

comment:7 Changed 9 years ago by Martyn Gigg

In [13595]:

Refs #3448 Add a switch for precompiled headers and turn it off while I figure out why the tests fail.

comment:8 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to verify
  • Resolution set to fixed

In [13703]:

Fixes #3448: Docs for MDEWFindPeaks

comment:9 Changed 9 years ago by Janik Zikovsky

In [13704]:

Refs #3448: Docs for MDEWFindPeaks

comment:10 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to reopened
  • Resolution fixed deleted

Oops I meant to commit to ticket #3449. Sorry!

comment:11 Changed 9 years ago by Martyn Gigg

In [13748]:

Reactivate the precompiled headers. The tests should now work, the issue was the the precompiled hedaer had caused exception handling to be disabled. A common header WrappedTestSuite is now in the cxxtest that is used by all of the PrecompiledHeader files in the tests. Refs #3448

comment:12 Changed 9 years ago by Martyn Gigg

In [14589]:

Refs #3448. Improve stability of precompiled header builds. This should avoid things being rebuilt so much.

comment:13 Changed 9 years ago by Martyn Gigg

In [14592]:

Refs #3448. Missed a file.

comment:14 Changed 9 years ago by Martyn Gigg

  • Status changed from reopened to accepted

comment:15 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:16 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:17 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

Working. Applied at the file level rather than at the project level, but working nevertheless.

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4295

Note: See TracTickets for help on using tickets.